Kevin Si created BEAM-4261:
------------------------------

             Summary: CloudBigtableIO should not try to validate runtime 
parameters at construction time.
                 Key: BEAM-4261
                 URL: https://issues.apache.org/jira/browse/BEAM-4261
             Project: Beam
          Issue Type: Bug
          Components: io-java-gcp
            Reporter: Kevin Si
            Assignee: Chamikara Jayalath


The workaround for user is to have some default values set and override them at 
runtime.

One example of validating runtime parameter at construction time is following, 
and there are could be more.

 
    @Override
    public void validate() {
      ValueProvider<String> tableId = config.getTableId();
      checkArgument(tableId != null && tableId.isAccessible() && 
!tableId.get().isEmpty(),
        "tableId was not supplied");
    }
 
A reported issue on stackoverflow: 
[https://stackoverflow.com/questions/49595921/valueprovider-type-parameters-not-getting-honored-at-the-template-execution-time]
 
One concern I have is that if we disable the validation at construction time, 
how do we validate it at runtime? Ideally, users should use template parameter 
metadata for validation, but that is optional.
 
 
 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to