[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88553
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 18:35
Start Date: 06/Apr/18 18:35
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5041: [BEAM-3250] Add
JUnit test reporting to Jenkins.
URL: https://github.com/apache/beam/pull/5041
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
index 512cfa976a1..f1c7e18c066 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
@@ -36,6 +36,11 @@ job('beam_PostCommit_Java_ValidatesRunner_Apex_Gradle') {
'--rerun-tasks',
]
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
index 318c834957f..5159f8afae2 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
@@ -37,6 +37,11 @@ job('beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle') {
'--rerun-tasks',
]
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink.groovy
index af9855adc89..6daed0bf95b 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink.groovy
@@ -34,6 +34,11 @@ job('beam_PostCommit_Java_ValidatesRunner_Flink_Gradle') {
'--rerun-tasks',
]
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
index 8ba0a71dc59..ef6b34ccdf8 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
@@ -39,6 +39,11 @@ job('beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle') {
'--rerun-tasks',
]
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
// Sets that this is a PostCommit job.
// 0 5 31 2 * will run on Feb 31 (i.e. never) according to job properties.
// In post-commit this job triggers only on SCM changes.
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
index 33c0d3f8f4d..7824e91e8d2 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
@@ -36,6 +36,11 @@ job('beam_PostCommit_Java_ValidatesRunner_Spark_Gradle') {
'--rerun-tasks',
]
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 88553)
Time Spent: 4h (was: 3h 50m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
>
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88552
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 18:31
Start Date: 06/Apr/18 18:31
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5041:
[BEAM-3250] Add JUnit test reporting to Jenkins.
URL: https://github.com/apache/beam/pull/5041#discussion_r179840994
##
File path:
.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
##
@@ -37,7 +37,12 @@ job('beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle')
{
'--rerun-tasks',
]
- // Sets that this is a PostCommit job.
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
+ // Sets that this is a PostCommit job.
Review comment:
Wow, annoying. Will fix.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 88552)
Time Spent: 3h 50m (was: 3h 40m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88546=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88546
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 18:23
Start Date: 06/Apr/18 18:23
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #5041:
[BEAM-3250] Add JUnit test reporting to Jenkins.
URL: https://github.com/apache/beam/pull/5041#discussion_r179838688
##
File path:
.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
##
@@ -37,7 +37,12 @@ job('beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle')
{
'--rerun-tasks',
]
- // Sets that this is a PostCommit job.
+ // Publish all test results to Jenkins
+ publishers {
+archiveJunit('**/build/test-results/**/*.xml')
+ }
+
+ // Sets that this is a PostCommit job.
Review comment:
I _believe_ there is an extra space before `//` and in other files as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 88546)
Time Spent: 3h 40m (was: 3.5h)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88544=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88544 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 06/Apr/18 18:15 Start Date: 06/Apr/18 18:15 Worklog Time Spent: 10m Work Description: lukecwik opened a new pull request #5041: [BEAM-3250] Add JUnit test reporting to Jenkins. URL: https://github.com/apache/beam/pull/5041 This helps debug post commit failures because we get to see the test failure appear part of the Jenkins UI. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 88544) Time Spent: 3.5h (was: 3h 20m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Fix For: 2.5.0 > > Time Spent: 3.5h > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88406=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88406
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 11:53
Start Date: 06/Apr/18 11:53
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5030: [BEAM-3250] Migrate
Spark ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5030
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
index b4a0d029db5..33c0d3f8f4d 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Spark.groovy
@@ -19,16 +19,22 @@
import common_job_properties
// This job runs the suite of ValidatesRunner tests against the Spark runner.
-mavenJob('beam_PostCommit_Java_ValidatesRunner_Spark') {
+job('beam_PostCommit_Java_ValidatesRunner_Spark_Gradle') {
description('Runs the ValidatesRunner suite on the Spark runner.')
-
+ previousNames('beam_PostCommit_Java_ValidatesRunner_Spark')
previousNames('beam_PostCommit_Java_RunnableOnService_Spark')
// Set common parameters.
common_job_properties.setTopLevelMainJobProperties(delegate, 'master', 120)
- // Set maven parameters.
- common_job_properties.setMavenConfig(delegate)
+ def gradle_switches = [
+// Gradle log verbosity enough to diagnose basic build issues
+"--info",
+// Continue the build even if there is a failure to show as many potential
failures as possible.
+'--continue',
+// Until we verify the build cache is working appropriately, force
rerunning all tasks
+'--rerun-tasks',
+ ]
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
@@ -39,6 +45,14 @@ mavenJob('beam_PostCommit_Java_ValidatesRunner_Spark') {
'Apache Spark Runner ValidatesRunner Tests',
'Run Spark ValidatesRunner')
- // Maven goals for this job.
- goals('-B -e clean verify -am -pl runners/spark
-Plocal-validates-runner-tests -Dspark.ui.enabled=false')
+ // Gradle goals for this job.
+ steps {
+gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+ tasks(':runners:spark:validatesRunner')
+ for (String gradle_switch : gradle_switches) {
+switches(gradle_switch)
+ }
+}
+ }
}
diff --git a/build_rules.gradle b/build_rules.gradle
index 77a794ca1c2..aad4fd13fe5 100644
--- a/build_rules.gradle
+++ b/build_rules.gradle
@@ -144,6 +144,7 @@ def apex_core_version = "3.6.0"
def apex_malhar_version = "3.4.0"
def postgres_version = "9.4.1212.jre7"
def jaxb_api_version = "2.2.12"
+def kafka_version = "1.0.0"
// A map of maps containing common libraries used per language. To use:
// dependencies {
@@ -227,7 +228,8 @@ ext.library = [
jaxb_api: "javax.xml.bind:jaxb-api:$jaxb_api_version",
joda_time: "joda-time:joda-time:2.4",
junit: "junit:junit:4.12",
-kafka_clients: "org.apache.kafka:kafka-clients:1.0.0",
+kafka_2_11: "org.apache.kafka:kafka_2.11:$kafka_version",
+kafka_clients: "org.apache.kafka:kafka-clients:$kafka_version",
malhar_library: "org.apache.apex:malhar-library:$apex_malhar_version",
mockito_core: "org.mockito:mockito-core:1.9.5",
netty_handler: "io.netty:netty-handler:$netty_version",
diff --git a/runners/spark/build.gradle b/runners/spark/build.gradle
index 7eccf4f405e..2a573de6c52 100644
--- a/runners/spark/build.gradle
+++ b/runners/spark/build.gradle
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+import groovy.json.JsonOutput
+
apply from: project(":").file("build_rules.gradle")
applyJavaNature(artifactId: "beam-runners-spark")
@@ -30,6 +32,11 @@ description = "Apache Beam :: Runners :: Spark"
*/
evaluationDependsOn(":model:fn-execution")
evaluationDependsOn(":runners:core-java")
+evaluationDependsOn(":sdks:java:core")
+
+configurations {
+ validatesRunner
+}
test {
systemProperty "beam.spark.test.reuseSparkContext", "true"
@@ -72,16 +79,21 @@ dependencies {
provided "org.apache.zookeeper:zookeeper:3.4.6"
provided "org.scala-lang:scala-library:2.11.8"
provided "com.esotericsoftware.kryo:kryo:2.21"
- testCompile project(path: ":sdks:java:io:kafka", configuration: "shadow")
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest project(path: ":sdks:java:io:kafka", configuration: "shadow")
+ shadowTest project(path: ":sdks:java:core",
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88405=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88405
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 11:46
Start Date: 06/Apr/18 11:46
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5029: [BEAM-3250] Migrate
Dataflow ValidatesRunner test to Gradle
URL: https://github.com/apache/beam/pull/5029
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
index 3230f9a5787..318c834957f 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Dataflow.groovy
@@ -20,16 +20,22 @@ import common_job_properties
// This job runs the suite of ValidatesRunner tests against the Dataflow
// runner.
-mavenJob('beam_PostCommit_Java_ValidatesRunner_Dataflow') {
+job('beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle') {
description('Runs the ValidatesRunner suite on the Dataflow runner.')
+ previousNames('beam_PostCommit_Java_ValidatesRunner_Dataflow')
previousNames('beam_PostCommit_Java_RunnableOnService_Dataflow')
-
// Set common parameters. Sets a long (3 hour) timeout due to timeouts in
[BEAM-3775].
common_job_properties.setTopLevelMainJobProperties(delegate, 'master', 180)
- // Set maven parameters.
- common_job_properties.setMavenConfig(delegate)
+ def gradle_switches = [
+// Gradle log verbosity enough to diagnose basic build issues
+"--info",
+// Continue the build even if there is a failure to show as many potential
failures as possible.
+'--continue',
+// Until we verify the build cache is working appropriately, force
rerunning all tasks
+'--rerun-tasks',
+ ]
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
@@ -40,6 +46,14 @@ mavenJob('beam_PostCommit_Java_ValidatesRunner_Dataflow') {
'Google Cloud Dataflow Runner ValidatesRunner Tests',
'Run Dataflow ValidatesRunner')
- // Maven goals for this job.
- goals('-B -e clean verify -am -pl runners/google-cloud-dataflow-java
-DforkCount=0 -DvalidatesRunnerPipelineOptions=\'[
"--runner=TestDataflowRunner", "--project=apache-beam-testing",
"--tempRoot=gs://temp-storage-for-validates-runner-tests/" ]\'')
+ // Gradle goals for this job.
+ steps {
+gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+ tasks(':runners:google-cloud-dataflow-java:validatesRunner')
+ for (String gradle_switch : gradle_switches) {
+switches(gradle_switch)
+ }
+}
+ }
}
diff --git a/runners/google-cloud-dataflow-java/build.gradle
b/runners/google-cloud-dataflow-java/build.gradle
index b75b97d9208..0c12e5aba9c 100644
--- a/runners/google-cloud-dataflow-java/build.gradle
+++ b/runners/google-cloud-dataflow-java/build.gradle
@@ -16,6 +16,8 @@
* limitations under the License.
*/
+import groovy.json.JsonOutput
+
apply from: project(":").file("build_rules.gradle")
applyJavaNature(enableFindbugs: false /* BEAM-925 */,
artifactId: "beam-runners-google-cloud-dataflow-java")
@@ -32,6 +34,7 @@ description = "Apache Beam :: Runners :: Google Cloud
Dataflow"
evaluationDependsOn(":sdks:java:io:google-cloud-platform")
evaluationDependsOn(":sdks:java:extensions:google-cloud-platform-core")
evaluationDependsOn(":model:fn-execution")
+evaluationDependsOn(":sdks:java:core")
processResources {
filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
@@ -47,6 +50,10 @@ test {
systemProperty "beamUseDummyRunner", "true"
}
+configurations {
+ validatesRunner
+}
+
dependencies {
compile library.java.guava
shadow project(path: ":model:pipeline", configuration: "shadow")
@@ -70,23 +77,60 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.junit
- testCompile
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
- testCompile library.java.guava_testlib
- testCompile library.java.slf4j_jdk14
- testCompile library.java.mockito_core
- testCompile library.java.google_cloud_dataflow_java_proto_library_all
- testCompile
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=88404=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88404
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 06/Apr/18 11:45
Start Date: 06/Apr/18 11:45
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5029:
[BEAM-3250] Migrate Dataflow ValidatesRunner test to Gradle
URL: https://github.com/apache/beam/pull/5029#discussion_r179733509
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -70,23 +77,60 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.junit
- testCompile
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
- testCompile library.java.guava_testlib
- testCompile library.java.slf4j_jdk14
- testCompile library.java.mockito_core
- testCompile library.java.google_cloud_dataflow_java_proto_library_all
- testCompile library.java.datastore_v1_protos
- testCompile library.java.jackson_dataformat_yaml
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.junit
+ shadowTest
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
+ shadowTest library.java.guava_testlib
+ shadowTest library.java.slf4j_jdk14
+ shadowTest library.java.mockito_core
+ shadowTest library.java.google_cloud_dataflow_java_proto_library_all
+ shadowTest library.java.datastore_v1_protos
+ shadowTest library.java.jackson_dataformat_yaml
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
}
test {
systemProperties = [ "beamUseDummyRunner" : "true" ]
}
+task validatesRunnerTest(type: Test) {
+ group = "Verification"
+ def dataflowProject = project.findProperty('dataflowProject') ?:
'apache-beam-testing'
+ def dataflowTempRoot = project.findProperty('dataflowTempRoot') ?:
'gs://temp-storage-for-validates-runner-tests/'
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestDataflowRunner",
+ "--project=${dataflowProject}",
+ "--tempRoot=${dataflowTempRoot}",
+ ])
+
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above10MB'
Review comment:
Sorry that I didn't see that and good catch on the 4 forks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 88404)
Time Spent: 3h (was: 2h 50m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87923=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87923 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 05/Apr/18 07:16 Start Date: 05/Apr/18 07:16 Worklog Time Spent: 10m Work Description: herohde commented on issue #5030: [BEAM-3250] Migrate Spark ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5030#issuecomment-378842371 R: @lukecwik The dependency failure that took me some time to figure out was that we used a wrong kafka version where a class was slightly renamed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87923) Time Spent: 2h 50m (was: 2h 40m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 2h 50m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87921=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87921 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 05/Apr/18 07:13 Start Date: 05/Apr/18 07:13 Worklog Time Spent: 10m Work Description: herohde opened a new pull request #5030: [BEAM-3250] Migrate Spark ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5030 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87921) Time Spent: 2h 40m (was: 2.5h) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87897=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87897
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 05/Apr/18 06:04
Start Date: 05/Apr/18 06:04
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5029:
[BEAM-3250] Migrate Dataflow ValidatesRunner test to Gradle
URL: https://github.com/apache/beam/pull/5029#discussion_r179356996
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -70,23 +77,60 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.junit
- testCompile
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
- testCompile library.java.guava_testlib
- testCompile library.java.slf4j_jdk14
- testCompile library.java.mockito_core
- testCompile library.java.google_cloud_dataflow_java_proto_library_all
- testCompile library.java.datastore_v1_protos
- testCompile library.java.jackson_dataformat_yaml
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.junit
+ shadowTest
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
+ shadowTest library.java.guava_testlib
+ shadowTest library.java.slf4j_jdk14
+ shadowTest library.java.mockito_core
+ shadowTest library.java.google_cloud_dataflow_java_proto_library_all
+ shadowTest library.java.datastore_v1_protos
+ shadowTest library.java.jackson_dataformat_yaml
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
}
test {
systemProperties = [ "beamUseDummyRunner" : "true" ]
}
+task validatesRunnerTest(type: Test) {
+ group = "Verification"
+ def dataflowProject = project.findProperty('dataflowProject') ?:
'apache-beam-testing'
+ def dataflowTempRoot = project.findProperty('dataflowTempRoot') ?:
'gs://temp-storage-for-validates-runner-tests/'
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestDataflowRunner",
+ "--project=${dataflowProject}",
+ "--tempRoot=${dataflowTempRoot}",
+ ])
+
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above10MB'
Review comment:
I got it from here:
https://github.com/apache/beam/blob/a2a5d3d7aa59b5cfde1c47a6286bcb3ccd7f8c85/runners/google-cloud-dataflow-java/pom.xml#L283
Happy to remove them, if I misread the pom.
On a separate note, I see I missed the parallelism -- it's executing
sequentially (which was useful for testing it), but is not what we want in
Jenkins.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87897)
Time Spent: 2.5h (was: 2h 20m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87865=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87865
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 05/Apr/18 03:07
Start Date: 05/Apr/18 03:07
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5029:
[BEAM-3250] Migrate Dataflow ValidatesRunner test to Gradle
URL: https://github.com/apache/beam/pull/5029#discussion_r179340496
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -70,23 +77,60 @@ dependencies {
shadow library.java.jackson_annotations
shadow library.java.jackson_databind
shadow library.java.slf4j_api
- testCompile library.java.hamcrest_core
- testCompile library.java.junit
- testCompile
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
- testCompile library.java.guava_testlib
- testCompile library.java.slf4j_jdk14
- testCompile library.java.mockito_core
- testCompile library.java.google_cloud_dataflow_java_proto_library_all
- testCompile library.java.datastore_v1_protos
- testCompile library.java.jackson_dataformat_yaml
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.junit
+ shadowTest
project(":sdks:java:io:google-cloud-platform").sourceSets.test.output
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest
project(":sdks:java:extensions:google-cloud-platform-core").sourceSets.test.output
+ shadowTest library.java.guava_testlib
+ shadowTest library.java.slf4j_jdk14
+ shadowTest library.java.mockito_core
+ shadowTest library.java.google_cloud_dataflow_java_proto_library_all
+ shadowTest library.java.datastore_v1_protos
+ shadowTest library.java.jackson_dataformat_yaml
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
}
test {
systemProperties = [ "beamUseDummyRunner" : "true" ]
}
+task validatesRunnerTest(type: Test) {
+ group = "Verification"
+ def dataflowProject = project.findProperty('dataflowProject') ?:
'apache-beam-testing'
+ def dataflowTempRoot = project.findProperty('dataflowTempRoot') ?:
'gs://temp-storage-for-validates-runner-tests/'
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestDataflowRunner",
+ "--project=${dataflowProject}",
+ "--tempRoot=${dataflowTempRoot}",
+ ])
+
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above10MB'
Review comment:
I don't see any excludes defined here:
https://github.com/apache/beam/blob/a2a5d3d7aa59b5cfde1c47a6286bcb3ccd7f8c85/runners/google-cloud-dataflow-java/pom.xml#L64
Is there another place where you got this list from?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87865)
Time Spent: 2h 20m (was: 2h 10m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87857 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 05/Apr/18 02:20 Start Date: 05/Apr/18 02:20 Worklog Time Spent: 10m Work Description: herohde opened a new pull request #5029: [BEAM-3250] Migrate Dataflow ValidatesRunner test to Gradle URL: https://github.com/apache/beam/pull/5029 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87857) Time Spent: 2h 10m (was: 2h) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87839=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87839
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 05/Apr/18 00:49
Start Date: 05/Apr/18 00:49
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #5025: [BEAM-3250] Migrate
Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
index c16a1e2f9d0..512cfa976a1 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Apex.groovy
@@ -19,15 +19,22 @@
import common_job_properties
// This job runs the suite of ValidatesRunner tests against the Apex runner.
-mavenJob('beam_PostCommit_Java_ValidatesRunner_Apex') {
+job('beam_PostCommit_Java_ValidatesRunner_Apex_Gradle') {
description('Runs the ValidatesRunner suite on the Apex runner.')
+ previousNames('beam_PostCommit_Java_ValidatesRunner_Apex')
previousNames('beam_PostCommit_Java_RunnableOnService_Apex')
// Set common parameters.
common_job_properties.setTopLevelMainJobProperties(delegate)
- // Set maven parameters.
- common_job_properties.setMavenConfig(delegate)
+ def gradle_switches = [
+// Gradle log verbosity enough to diagnose basic build issues
+"--info",
+// Continue the build even if there is a failure to show as many potential
failures as possible.
+'--continue',
+// Until we verify the build cache is working appropriately, force
rerunning all tasks
+'--rerun-tasks',
+ ]
// Sets that this is a PostCommit job.
common_job_properties.setPostCommit(delegate)
@@ -38,11 +45,14 @@ mavenJob('beam_PostCommit_Java_ValidatesRunner_Apex') {
'Apache Apex Runner ValidatesRunner Tests',
'Run Apex ValidatesRunner')
- // Maven goals for this job.
- goals('''clean verify --projects runners/apex \
- --also-make \
- --batch-mode \
- --errors \
- --activate-profiles validates-runner-tests \
- --activate-profiles local-validates-runner-tests''')
+ // Gradle goals for this job.
+ steps {
+gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+ tasks(':runners:apex:validatesRunner')
+ for (String gradle_switch : gradle_switches) {
+switches(gradle_switch)
+ }
+}
+ }
}
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
index e1cbafe6e4b..8ba0a71dc59 100644
---
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Gearpump.groovy
@@ -20,9 +20,9 @@ import common_job_properties
// This job runs the suite of ValidatesRunner tests against the Gearpump
// runner.
-mavenJob('beam_PostCommit_Java_ValidatesRunner_Gearpump') {
+job('beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle') {
description('Runs the ValidatesRunner suite on the Gearpump runner.')
-
+ previousNames('beam_PostCommit_Java_ValidatesRunner_Gearpump')
previousNames('beam_PostCommit_Java_RunnableOnService_Gearpump')
// Set common parameters.
@@ -30,8 +30,14 @@ mavenJob('beam_PostCommit_Java_ValidatesRunner_Gearpump') {
delegate,
'gearpump-runner')
- // Set maven parameters.
- common_job_properties.setMavenConfig(delegate)
+ def gradle_switches = [
+// Gradle log verbosity enough to diagnose basic build issues
+"--info",
+// Continue the build even if there is a failure to show as many potential
failures as possible.
+'--continue',
+// Until we verify the build cache is working appropriately, force
rerunning all tasks
+'--rerun-tasks',
+ ]
// Sets that this is a PostCommit job.
// 0 5 31 2 * will run on Feb 31 (i.e. never) according to job properties.
@@ -44,6 +50,14 @@ mavenJob('beam_PostCommit_Java_ValidatesRunner_Gearpump') {
'Apache Gearpump Runner ValidatesRunner Tests',
'Run Gearpump ValidatesRunner')
- // Maven goals for this job.
- goals('-B -e clean verify -am -pl runners/gearpump -DforkCount=0
-DvalidatesRunnerPipelineOptions=\'[ "--runner=TestGearpumpRunner"]\'')
+ // Gradle goals for this job.
+ steps {
+gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87817=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87817 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 04/Apr/18 23:26 Start Date: 04/Apr/18 23:26 Worklog Time Spent: 10m Work Description: herohde commented on issue #5025: [BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5025#issuecomment-378776123 Run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87817) Time Spent: 1h 50m (was: 1h 40m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87815=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87815
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 23:25
Start Date: 04/Apr/18 23:25
Worklog Time Spent: 10m
Work Description: herohde commented on a change in pull request #5025:
[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025#discussion_r179312315
##
File path: runners/gearpump/build.gradle
##
@@ -35,10 +43,40 @@ dependencies {
shadow library.java.joda_time
shadow library.java.jackson_annotations
shadow library.java.findbugs_jsr305
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile library.java.junit
- testCompile library.java.hamcrest_core
- testCompile library.java.jackson_databind
- testCompile library.java.jackson_dataformat_yaml
- testCompile library.java.mockito_core
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest library.java.junit
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.jackson_databind
+ shadowTest library.java.jackson_dataformat_yaml
+ shadowTest library.java.mockito_core
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
+}
+
+task validatesRunnerStreaming (type: Test) {
+ group = "Verification"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestGearpumpRunner",
+ "--streaming=true",
+ ])
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+excludeCategories
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
Review comment:
Done
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87815)
Time Spent: 1.5h (was: 1h 20m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87816=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87816 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 04/Apr/18 23:25 Start Date: 04/Apr/18 23:25 Worklog Time Spent: 10m Work Description: herohde commented on issue #5025: [BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5025#issuecomment-378775911 Thanks @lukecwik. PTAL This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87816) Time Spent: 1h 40m (was: 1.5h) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87808=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87808
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 23:12
Start Date: 04/Apr/18 23:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5025:
[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025#discussion_r179309731
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/testing/UsesParDoLifecycle.java
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.beam.sdk.testing;
+
+/**
+ * Category tag for the ParDoLifecycleTest for exclusion (BEAM-3241).
+ */
+public class UsesParDoLifecycle {}
Review comment:
Use interface instead of class
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87808)
Time Spent: 1h 10m (was: 1h)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87809
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 23:12
Start Date: 04/Apr/18 23:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5025:
[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025#discussion_r179310247
##
File path: runners/apex/build.gradle
##
@@ -73,5 +82,31 @@ task buildDependencyTree(type: DependencyReportTask) {
}
compileJava.dependsOn buildDependencyTree
+task validatesRunnerBatch (type: Test) {
Review comment:
nit: spacing `validatesRunnerBatch (` -> `validatesRunnerBatch(`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87809)
Time Spent: 1h 20m (was: 1h 10m)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87806=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87806
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 23:12
Start Date: 04/Apr/18 23:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5025:
[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025#discussion_r179309485
##
File path: runners/gearpump/build.gradle
##
@@ -35,10 +43,40 @@ dependencies {
shadow library.java.joda_time
shadow library.java.jackson_annotations
shadow library.java.findbugs_jsr305
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile library.java.junit
- testCompile library.java.hamcrest_core
- testCompile library.java.jackson_databind
- testCompile library.java.jackson_dataformat_yaml
- testCompile library.java.mockito_core
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest library.java.junit
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.jackson_databind
+ shadowTest library.java.jackson_dataformat_yaml
+ shadowTest library.java.mockito_core
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
+}
+
+task validatesRunnerStreaming (type: Test) {
+ group = "Verification"
+ systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+ "--runner=TestGearpumpRunner",
+ "--streaming=true",
+ ])
+
+ classpath = configurations.validatesRunner
+ testClassesDirs =
files(project(":sdks:java:core").sourceSets.test.output.classesDirs)
+ useJUnit {
+includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+excludeCategories
'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
Review comment:
These seem like the wrong exclude categories when compared to
https://github.com/apache/beam/blob/5caa883f191ca4cd9158694ae94a673edbc7b4d5/runners/gearpump/pom.xml#L72
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87806)
Time Spent: 1h 10m (was: 1h)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87807=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87807
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 23:12
Start Date: 04/Apr/18 23:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5025:
[BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle
URL: https://github.com/apache/beam/pull/5025#discussion_r179310219
##
File path: runners/gearpump/build.gradle
##
@@ -35,10 +43,40 @@ dependencies {
shadow library.java.joda_time
shadow library.java.jackson_annotations
shadow library.java.findbugs_jsr305
- testCompile project(path: ":sdks:java:core", configuration: "shadowTest")
- testCompile library.java.junit
- testCompile library.java.hamcrest_core
- testCompile library.java.jackson_databind
- testCompile library.java.jackson_dataformat_yaml
- testCompile library.java.mockito_core
+ shadowTest project(path: ":sdks:java:core", configuration: "shadowTest")
+ shadowTest library.java.junit
+ shadowTest library.java.hamcrest_core
+ shadowTest library.java.jackson_databind
+ shadowTest library.java.jackson_dataformat_yaml
+ shadowTest library.java.mockito_core
+ validatesRunner project(path: ":sdks:java:core", configuration: "shadowTest")
+ validatesRunner project(path: project.path, configuration: "shadow")
+}
+
+task validatesRunnerStreaming (type: Test) {
Review comment:
nit: spacing `validatesRunnerStreaming (` -> `validatesRunnerStreaming(`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87807)
Time Spent: 1h 10m (was: 1h)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Henning Rohde
>Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87802=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87802 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 04/Apr/18 23:02 Start Date: 04/Apr/18 23:02 Worklog Time Spent: 10m Work Description: herohde commented on issue #5025: [BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5025#issuecomment-378771854 Run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87802) Time Spent: 1h (was: 50m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87794=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87794 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 04/Apr/18 22:47 Start Date: 04/Apr/18 22:47 Worklog Time Spent: 10m Work Description: herohde opened a new pull request #5025: [BEAM-3250] Migrate Apex and Gearpump ValidatesRunner tests to Gradle URL: https://github.com/apache/beam/pull/5025 * Added a new test category to exclude ParDoLifecycleTest This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87794) Time Spent: 50m (was: 40m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Henning Rohde >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[
https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87609
]
ASF GitHub Bot logged work on BEAM-3250:
Author: ASF GitHub Bot
Created on: 04/Apr/18 16:03
Start Date: 04/Apr/18 16:03
Worklog Time Spent: 10m
Work Description: asfgit closed pull request #5012: [BEAM-3250] Creating
a Gradle Jenkins config for Flink PostCommit.
URL: https://github.com/apache/beam/pull/5012
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink_GradleBuild.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink_GradleBuild.groovy
new file mode 100644
index 000..b9bd941720f
--- /dev/null
+++
b/.test-infra/jenkins/job_beam_PostCommit_Java_ValidatesRunner_Flink_GradleBuild.groovy
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import common_job_properties
+
+// This job runs the suite of ValidatesRunner tests against the Flink runner.
+job('beam_PostCommit_Java_ValidatesRunner_Flink') {
+ description('Runs the ValidatesRunner suite on the Flink runner.')
+
+ // Set common parameters.
+ common_job_properties.setTopLevelMainJobProperties(delegate)
+
+ def gradle_switches = [
+// Gradle log verbosity enough to diagnose basic build issues
+"--info",
+// Continue the build even if there is a failure to show as many potential
failures as possible.
+'--continue',
+// Until we verify the build cache is working appropriately, force
rerunning all tasks
+'--rerun-tasks',
+ ]
+
+ // Sets that this is a PostCommit job.
+ common_job_properties.setPostCommit(delegate)
+
+ // Allows triggering this build against pull requests.
+ common_job_properties.enablePhraseTriggeringFromPullRequest(
+delegate,
+'Apache Flink Runner ValidatesRunner Gradle Tests',
+'Run Flink ValidatesRunner Gradle')
+
+ // Gradle goals for this job.
+ steps {
+gradle {
+ rootBuildScriptDir(common_job_properties.checkoutDir)
+ tasks(':runners:flink:validatesRunner')
+ for (String gradle_switch : gradle_switches) {
+switches(gradle_switch)
+ }
+}
+ }
+}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 87609)
Time Spent: 40m (was: 0.5h)
> Migrate ValidatesRunner Jenkins PostCommits to Gradle
> -
>
> Key: BEAM-3250
> URL: https://issues.apache.org/jira/browse/BEAM-3250
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
>Reporter: Luke Cwik
>Assignee: Alex Amato
>Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Update these targets to execute ValidatesRunner tests:
> https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87429 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 04/Apr/18 05:20 Start Date: 04/Apr/18 05:20 Worklog Time Spent: 10m Work Description: youngoli commented on issue #5012: [BEAM-3250] Creating a Gradle Jenkins config for Flink PostCommit. URL: https://github.com/apache/beam/pull/5012#issuecomment-378483382 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87429) Time Spent: 0.5h (was: 20m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Alex Amato >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87333=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87333 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 03/Apr/18 23:23 Start Date: 03/Apr/18 23:23 Worklog Time Spent: 10m Work Description: youngoli commented on issue #5012: [BEAM-3250] Creating a Gradle Jenkins config for Flink PostCommit. URL: https://github.com/apache/beam/pull/5012#issuecomment-378430574 @ajamato This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87333) Time Spent: 20m (was: 10m) > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Alex Amato >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3250) Migrate ValidatesRunner Jenkins PostCommits to Gradle
[ https://issues.apache.org/jira/browse/BEAM-3250?focusedWorklogId=87332=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87332 ] ASF GitHub Bot logged work on BEAM-3250: Author: ASF GitHub Bot Created on: 03/Apr/18 23:23 Start Date: 03/Apr/18 23:23 Worklog Time Spent: 10m Work Description: youngoli opened a new pull request #5012: [BEAM-3250] Creating a Gradle Jenkins config for Flink PostCommit. URL: https://github.com/apache/beam/pull/5012 Started with the Flink PostCommit first because a Gradle config for it was already written. This is my attempt at creating a simple Gradle config before moving onto the more complex PostCommits. It just executes the Gradle :runners:flink:validatesRunner task. NOTE: I still need to create a seed job and test this on Jenkins. I will post a comment confirming that this has been tested once I do so. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [x] Write a pull request description that is detailed enough to understand: - [x] What the pull request does - [x] Why it does it - [x] How it does it - [x] Why this approach - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 87332) Time Spent: 10m Remaining Estimate: 0h > Migrate ValidatesRunner Jenkins PostCommits to Gradle > - > > Key: BEAM-3250 > URL: https://issues.apache.org/jira/browse/BEAM-3250 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing >Reporter: Luke Cwik >Assignee: Alex Amato >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Update these targets to execute ValidatesRunner tests: > https://github.com/apache/beam/search?l=Groovy=ValidatesRunner==%E2%9C%93 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
