[jira] [Work logged] (BEAM-5714) RedisIO emit error of EXEC without MULTI
[ https://issues.apache.org/jira/browse/BEAM-5714?focusedWorklogId=154070&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-154070 ] ASF GitHub Bot logged work on BEAM-5714: Author: ASF GitHub Bot Created on: 13/Oct/18 00:47 Start Date: 13/Oct/18 00:47 Worklog Time Spent: 10m Work Description: aaltay commented on issue #6651: [BEAM-5714] Fix RedisIO EXEC without MULTI error URL: https://github.com/apache/beam/pull/6651#issuecomment-429497451 cc: @vvarma might have an opinion This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 154070) Time Spent: 40m (was: 0.5h) > RedisIO emit error of EXEC without MULTI > > > Key: BEAM-5714 > URL: https://issues.apache.org/jira/browse/BEAM-5714 > Project: Beam > Issue Type: Bug > Components: io-java-redis >Affects Versions: 2.7.0 >Reporter: K.K. POON >Assignee: Jean-Baptiste Onofré >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > RedisIO has EXEC without MULTI error after SET a batch of records. > > By looking at the source code, I guess there is missing `pipeline.multi();` > after exec() the last batch. > [https://github.com/apache/beam/blob/master/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L555] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5714) RedisIO emit error of EXEC without MULTI
[ https://issues.apache.org/jira/browse/BEAM-5714?focusedWorklogId=153936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153936 ] ASF GitHub Bot logged work on BEAM-5714: Author: ASF GitHub Bot Created on: 12/Oct/18 16:38 Start Date: 12/Oct/18 16:38 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #6651: [BEAM-5714] Fix RedisIO EXEC without MULTI error URL: https://github.com/apache/beam/pull/6651#issuecomment-429386703 R: @jbonofre are you the expert on RedisIO? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153936) Time Spent: 0.5h (was: 20m) > RedisIO emit error of EXEC without MULTI > > > Key: BEAM-5714 > URL: https://issues.apache.org/jira/browse/BEAM-5714 > Project: Beam > Issue Type: Bug > Components: io-java-redis >Affects Versions: 2.7.0 >Reporter: K.K. POON >Assignee: Jean-Baptiste Onofré >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > RedisIO has EXEC without MULTI error after SET a batch of records. > > By looking at the source code, I guess there is missing `pipeline.multi();` > after exec() the last batch. > [https://github.com/apache/beam/blob/master/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L555] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5714) RedisIO emit error of EXEC without MULTI
[ https://issues.apache.org/jira/browse/BEAM-5714?focusedWorklogId=153816&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153816 ] ASF GitHub Bot logged work on BEAM-5714: Author: ASF GitHub Bot Created on: 12/Oct/18 08:20 Start Date: 12/Oct/18 08:20 Worklog Time Spent: 10m Work Description: kkpoon commented on issue #6651: [BEAM-5714] Fix RedisIO EXEC without MULTI error URL: https://github.com/apache/beam/pull/6651#issuecomment-429245280 Dear Java code owners (@lukecwik @kennknowles @aaltay), May I have your review on this fix? 🤝 Thank you very much This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153816) Time Spent: 20m (was: 10m) > RedisIO emit error of EXEC without MULTI > > > Key: BEAM-5714 > URL: https://issues.apache.org/jira/browse/BEAM-5714 > Project: Beam > Issue Type: Bug > Components: io-java-redis >Affects Versions: 2.7.0 >Reporter: K.K. POON >Assignee: Jean-Baptiste Onofré >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > RedisIO has EXEC without MULTI error after SET a batch of records. > > By looking at the source code, I guess there is missing `pipeline.multi();` > after exec() the last batch. > [https://github.com/apache/beam/blob/master/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L555] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-5714) RedisIO emit error of EXEC without MULTI
[ https://issues.apache.org/jira/browse/BEAM-5714?focusedWorklogId=153374&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153374 ] ASF GitHub Bot logged work on BEAM-5714: Author: ASF GitHub Bot Created on: 11/Oct/18 03:06 Start Date: 11/Oct/18 03:06 Worklog Time Spent: 10m Work Description: kkpoon opened a new pull request #6651: [BEAM-5714] Fix RedisIO EXEC without MULTI error URL: https://github.com/apache/beam/pull/6651 ## Problem RedisIO has EXEC without MULTI error after set a batch of records. After investigate the source code, I guess there is missing `pipeline.multi();` after exec() the last batch. https://github.com/apache/beam/blob/master/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L555 ## Solution - re-initiate the MULTI after batch EXEC Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153374) Time Spent: 10m Remaining Es