Repository: incubator-beam Updated Branches: refs/heads/master 6c6f824aa -> 307819327
Tighten up tests for StateId validation Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/507cba8f Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/507cba8f Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/507cba8f Branch: refs/heads/master Commit: 507cba8f0df44b1c11c7621f00ff492243bdd1f1 Parents: 4e14ac2 Author: Kenneth Knowles <k...@google.com> Authored: Thu Oct 13 23:18:40 2016 -0700 Committer: Kenneth Knowles <k...@google.com> Committed: Tue Oct 18 13:08:55 2016 -0700 ---------------------------------------------------------------------- .../apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/507cba8f/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java index 26a7b74..230e6ca 100644 --- a/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java +++ b/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnSignaturesTest.java @@ -139,7 +139,7 @@ public class DoFnSignaturesTest { DoFnSignatures.INSTANCE.getSignature( new DoFn<String, String>() { @StateId("foo") - String bizzle = "bazzle"; + private final String bizzle = "bazzle"; @ProcessElement public void foo(ProcessContext context) {} @@ -162,7 +162,8 @@ public class DoFnSignaturesTest { StateSpecs.value(VarIntCoder.of()); @StateId("my-state-id") - StateSpec<Object, ValueState<Long>> myfield2 = StateSpecs.value(VarLongCoder.of()); + private final StateSpec<Object, ValueState<Long>> myfield2 = + StateSpecs.value(VarLongCoder.of()); @ProcessElement public void foo(ProcessContext context) {} @@ -245,6 +246,7 @@ public class DoFnSignaturesTest { Matchers.<TypeDescriptor<?>>equalTo(new TypeDescriptor<ValueState<Integer>>() {})); } + private static class DoFnForTestSimpleStateIdNamedDoFn extends DoFn<KV<String, Integer>, Long> { @StateId("foo") private final StateSpec<Object, ValueState<Integer>> bizzle =
