[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-24 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602964#comment-15602964 ] Amit Sela commented on BEAM-696: After further discussion in dev list this seems like a documentation issue.

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-24 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602952#comment-15602952 ] Amit Sela commented on BEAM-696: Yep, found that piece of code ;) thanks. > Side-Inputs non-deterministic

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-24 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15602937#comment-15602937 ] Aljoscha Krettek commented on BEAM-696: --- Just a clarification, the Flink runner does not pre combine

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-19 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589398#comment-15589398 ] Amit Sela commented on BEAM-696: I'm not sure about the Direct/Dataflow runners, but as for Flink, Aljoscha

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-19 Thread Daniel Halperin (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589321#comment-15589321 ] Daniel Halperin commented on BEAM-696: -- Let me try to restate what Kenn said above, and see if that

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-19 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589165#comment-15589165 ] Kenneth Knowles commented on BEAM-696: -- My preference would be to err on the side of matching the

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-19 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588988#comment-15588988 ] Amit Sela commented on BEAM-696: Following my last comment, and after further thought, I think that when

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-12 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15569001#comment-15569001 ] Aljoscha Krettek commented on BEAM-696: --- Flink doesn't use bundles but it just keeps all the elements

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-11 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566498#comment-15566498 ] Amit Sela commented on BEAM-696: Does Dataflow "buffer until trigger..." if there are no sideInputs assigned

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-11 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566305#comment-15566305 ] Kenneth Knowles commented on BEAM-696: -- I think there's some conflation of elements coming out of

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-11 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565305#comment-15565305 ] Amit Sela commented on BEAM-696: Correct me of I'm wrong - I think we all agree that sideInput for merging

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-11 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565302#comment-15565302 ] Amit Sela commented on BEAM-696: I wonder though, does Flink also use bundles ? so it buffers until a

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-11 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15565001#comment-15565001 ] Aljoscha Krettek commented on BEAM-696: --- Just to make it clear what the Flink runner does for this:

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-10 Thread Pei He (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563569#comment-15563569 ] Pei He commented on BEAM-696: - re: to "Sessions is not allowed in side inputs" There are two WindowFns involved,

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-04 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546539#comment-15546539 ] Amit Sela commented on BEAM-696: So it runs once, on the merged window ? That happens in the bundle level,

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-04 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546538#comment-15546538 ] Amit Sela commented on BEAM-696: So it runs once, on the merged window ? That happens in the bundle level,

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-04 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546473#comment-15546473 ] Kenneth Knowles commented on BEAM-696: -- Ben points out (in person) that this latter spec is already the

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-04 Thread Kenneth Knowles (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546263#comment-15546263 ] Kenneth Knowles commented on BEAM-696: -- The SDK needs to lay out a spec, which I think is what Pei is

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-04 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544926#comment-15544926 ] Amit Sela commented on BEAM-696: [~pei...@gmail.com] shouldn't the SDK take care/enforce this behaviour and

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-03 Thread Pei He (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543681#comment-15543681 ] Pei He commented on BEAM-696: - For merging windows, DataflowPipelineRunner does "defer running anything that

[jira] [Commented] (BEAM-696) Side-Inputs non-deterministic with merging main-input windows

2016-10-01 Thread Amit Sela (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538364#comment-15538364 ] Amit Sela commented on BEAM-696: I will add that the assertions are not failing in the DirectRunner as it