Repository: incubator-beam Updated Branches: refs/heads/master d299e2c25 -> 7dc1a4047
Add super.populateDisplayData() to standard implementations. The current super implementation is a no-op, but this is the recommended way to implement the pattern Project: http://git-wip-us.apache.org/repos/asf/incubator-beam/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-beam/commit/c6690c18 Tree: http://git-wip-us.apache.org/repos/asf/incubator-beam/tree/c6690c18 Diff: http://git-wip-us.apache.org/repos/asf/incubator-beam/diff/c6690c18 Branch: refs/heads/master Commit: c6690c18a64ec6c7971712ab43807b13c1849571 Parents: 9d45a4a Author: Scott Wegner <sweg...@google.com> Authored: Mon Apr 25 09:41:07 2016 -0700 Committer: bchambers <bchamb...@google.com> Committed: Tue Apr 26 09:39:01 2016 -0700 ---------------------------------------------------------------------- .../main/java/org/apache/beam/sdk/io/DatastoreIO.java | 1 + .../core/src/main/java/org/apache/beam/sdk/io/Read.java | 2 ++ .../core/src/main/java/org/apache/beam/sdk/io/Write.java | 1 + .../apache/beam/sdk/transforms/ApproximateQuantiles.java | 1 + .../apache/beam/sdk/transforms/ApproximateUnique.java | 2 ++ .../java/org/apache/beam/sdk/transforms/Combine.java | 11 +++++++++++ .../java/org/apache/beam/sdk/transforms/CombineFns.java | 4 ++++ .../apache/beam/sdk/transforms/CombineWithContext.java | 1 + .../main/java/org/apache/beam/sdk/transforms/Filter.java | 4 ++++ .../java/org/apache/beam/sdk/transforms/GroupByKey.java | 1 + .../beam/sdk/transforms/IntraBundleParallelization.java | 1 + .../main/java/org/apache/beam/sdk/transforms/Max.java | 1 + .../main/java/org/apache/beam/sdk/transforms/Min.java | 1 + .../main/java/org/apache/beam/sdk/transforms/ParDo.java | 2 ++ .../java/org/apache/beam/sdk/transforms/Partition.java | 2 ++ .../main/java/org/apache/beam/sdk/transforms/Sample.java | 2 ++ .../main/java/org/apache/beam/sdk/transforms/Top.java | 1 + .../beam/sdk/transforms/windowing/CalendarWindows.java | 6 ++++++ .../beam/sdk/transforms/windowing/FixedWindows.java | 1 + .../apache/beam/sdk/transforms/windowing/Sessions.java | 1 + .../beam/sdk/transforms/windowing/SlidingWindows.java | 1 + .../org/apache/beam/sdk/transforms/windowing/Window.java | 1 + .../java/org/apache/beam/sdk/util/CombineFnUtil.java | 1 + 23 files changed, 49 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/io/DatastoreIO.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/DatastoreIO.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/DatastoreIO.java index 4348950..c265659 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/DatastoreIO.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/DatastoreIO.java @@ -604,6 +604,7 @@ public class DatastoreIO { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .addIfNotDefault("host", host, DEFAULT_HOST) .addIfNotNull("dataset", datasetId); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java index 1f41e5c..05b70ac 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java @@ -147,6 +147,7 @@ public class Read { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("source", source.getClass()) .include(source); @@ -261,6 +262,7 @@ public class Read { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("source", source.getClass()) .include(source); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Write.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Write.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Write.java index b8fa259..a7d182d 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Write.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/Write.java @@ -79,6 +79,7 @@ public class Write { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("sink", sink.getClass()) .include(sink); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java index c58c736..dd99b9a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java @@ -363,6 +363,7 @@ public class ApproximateQuantiles { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("numQuantiles", numQuantiles) .add("comparer", compareFn.getClass()); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java index 175897b..46bad0c 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateUnique.java @@ -216,6 +216,7 @@ public class ApproximateUnique { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); ApproximateUnique.populateDisplayData(builder, sampleSize, maximumEstimationError); } } @@ -289,6 +290,7 @@ public class ApproximateUnique { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); ApproximateUnique.populateDisplayData(builder, sampleSize, maximumEstimationError); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java index 3566fa5..b13b0fc 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java @@ -515,6 +515,7 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFn.this.populateDisplayData(builder); } }; @@ -1193,6 +1194,7 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); KeyedCombineFn.this.populateDisplayData(builder); } }; @@ -1378,6 +1380,8 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + Combine.populateDisplayData(builder, fn, fnClass); Combine.populateGlobalDisplayData(builder, fanout, insertDefault); } @@ -1507,6 +1511,8 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + Combine.populateDisplayData(builder, fn, fnClass); Combine.populateGlobalDisplayData(builder, fanout, insertDefault); } @@ -1591,6 +1597,7 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("combineFn", combiner.getClass()); } @@ -1772,6 +1779,7 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Combine.populateDisplayData(builder, fn, fnClass); } } @@ -2077,6 +2085,8 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + Combine.populateDisplayData(builder, fn, fnClass); builder.add("fanoutFn", hotKeyFanout.getClass()); } @@ -2333,6 +2343,7 @@ public class Combine { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Combine.populateDisplayData(builder, fn, fnClass); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java index ed45498..a9500d8 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineFns.java @@ -464,6 +464,7 @@ public class CombineFns { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFns.populateDisplayData(builder, combineFns); } } @@ -602,6 +603,7 @@ public class CombineFns { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFns.populateDisplayData(builder, combineFnWithContexts); } } @@ -788,6 +790,7 @@ public class CombineFns { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFns.populateDisplayData(builder, keyedCombineFns); } } @@ -939,6 +942,7 @@ public class CombineFns { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFns.populateDisplayData(builder, keyedCombineFns); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineWithContext.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineWithContext.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineWithContext.java index 9bb4a01..9722360 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineWithContext.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/CombineWithContext.java @@ -171,6 +171,7 @@ public class CombineWithContext { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); CombineFnWithContext.this.populateDisplayData(builder); } }; http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java index 0e5e4a6..0108958 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Filter.java @@ -103,6 +103,7 @@ public class Filter<T> extends PTransform<PCollection<T>, PCollection<T>> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Filter.populateDisplayData(builder, String.format("x < %s", value)); } }); @@ -141,6 +142,7 @@ public class Filter<T> extends PTransform<PCollection<T>, PCollection<T>> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Filter.populateDisplayData(builder, String.format("x > %s", value)); } }); @@ -178,6 +180,7 @@ public class Filter<T> extends PTransform<PCollection<T>, PCollection<T>> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Filter.populateDisplayData(builder, String.format("x ⤠%s", value)); } }); @@ -215,6 +218,7 @@ public class Filter<T> extends PTransform<PCollection<T>, PCollection<T>> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); Filter.populateDisplayData(builder, String.format("x ⥠%s", value)); } }); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java index 1b3c454..0e46a2a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupByKey.java @@ -277,6 +277,7 @@ public class GroupByKey<K, V> @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); if (fewKeys) { builder.add("fewKeys", true); } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/IntraBundleParallelization.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/IntraBundleParallelization.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/IntraBundleParallelization.java index 1b91562..36149ca 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/IntraBundleParallelization.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/IntraBundleParallelization.java @@ -176,6 +176,7 @@ public class IntraBundleParallelization { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("maxParallelism", maxParallelism) .add("fn", doFn.getClass()) http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java index 28749d7..96900b4 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Max.java @@ -208,6 +208,7 @@ public class Max { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("comparer", comparator.getClass()); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java index 8f3082e..7d69c5a 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Min.java @@ -208,6 +208,7 @@ public class Min { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("comparer", comparator.getClass()); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java index cb1df18..547486d 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ParDo.java @@ -814,6 +814,7 @@ public class ParDo { */ @Override public void populateDisplayData(Builder builder) { + super.populateDisplayData(builder); ParDo.populateDisplayData(builder, fn, fnClass); } @@ -1051,6 +1052,7 @@ public class ParDo { @Override public void populateDisplayData(Builder builder) { + super.populateDisplayData(builder); ParDo.populateDisplayData(builder, fn, fnClass); } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java index 5366fd0..fbdb9be 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java @@ -124,6 +124,7 @@ public class Partition<T> extends PTransform<PCollection<T>, PCollectionList<T>> @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.include(partitionDoFn); } @@ -179,6 +180,7 @@ public class Partition<T> extends PTransform<PCollection<T>, PCollectionList<T>> @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("numPartitions", numPartitions) .add("partitionFn", partitionFn.getClass()); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java index 6362bd4..2fba5e3 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sample.java @@ -157,6 +157,7 @@ public class Sample { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("sampleSize", limit); } } @@ -256,6 +257,7 @@ public class Sample { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("sampleSize", sampleSize); } } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Top.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Top.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Top.java index 4b366bc..2d38e04 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Top.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Top.java @@ -395,6 +395,7 @@ new TopCombineFn<>(count, new Largest<V>()).<K>asKeyedFn()) @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("count", count) .add("comparer", compareFn.getClass()); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/CalendarWindows.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/CalendarWindows.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/CalendarWindows.java index 8656537..3084059 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/CalendarWindows.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/CalendarWindows.java @@ -147,6 +147,8 @@ public class CalendarWindows { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + builder .add("numDays", number) .addIfNotDefault("startDate", new DateTime(startDate, timeZone).toInstant(), @@ -242,6 +244,8 @@ public class CalendarWindows { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + builder .add("numMonths", number) .addIfNotDefault("startDate", new DateTime(startDate, timeZone).toInstant(), @@ -346,6 +350,8 @@ public class CalendarWindows { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); + builder .add("numYears", number) .addIfNotDefault("startDate", new DateTime(startDate, timeZone).toInstant(), http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/FixedWindows.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/FixedWindows.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/FixedWindows.java index bba1f3b..fdffebe 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/FixedWindows.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/FixedWindows.java @@ -85,6 +85,7 @@ public class FixedWindows extends PartitioningWindowFn<Object, IntervalWindow> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("size", size) .addIfNotDefault("offset", offset, Duration.ZERO); http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Sessions.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Sessions.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Sessions.java index 74ca268..7010256 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Sessions.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Sessions.java @@ -100,6 +100,7 @@ public class Sessions extends WindowFn<Object, IntervalWindow> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder.add("gapDuration", gapDuration); } http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java index abb4078..bbbedad 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/SlidingWindows.java @@ -142,6 +142,7 @@ public class SlidingWindows extends NonMergingWindowFn<Object, IntervalWindow> { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("size", size) .add("period", period) http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java index da512b8..b751bec 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/windowing/Window.java @@ -598,6 +598,7 @@ public class Window { @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); builder .add("windowFn", windowFn.getClass()) .include(windowFn) http://git-wip-us.apache.org/repos/asf/incubator-beam/blob/c6690c18/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java index 34197f7..351a158 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/util/CombineFnUtil.java @@ -104,6 +104,7 @@ public class CombineFnUtil { } @Override public void populateDisplayData(DisplayData.Builder builder) { + super.populateDisplayData(builder); combineFn.populateDisplayData(builder); } };
