[jira] [Commented] (BEAM-1148) Port PAssert away from Aggregators
[ https://issues.apache.org/jira/browse/BEAM-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749192#comment-15749192 ] Kenneth Knowles commented on BEAM-1148: --- The trouble with side output + combine is that we don't have access to the result via PipelineResult. So I think there's actual design work here. > Port PAssert away from Aggregators > -- > > Key: BEAM-1148 > URL: https://issues.apache.org/jira/browse/BEAM-1148 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core >Reporter: Kenneth Knowles > > One step in the removal of Aggregators (in favor of Metrics) is to remove our > reliance on them for PAssert checking. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-1148) Port PAssert away from Aggregators
[ https://issues.apache.org/jira/browse/BEAM-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15749188#comment-15749188 ] Ben Chambers commented on BEAM-1148: In general: Aggregators are being replaced with Metrics for the "monitoring" use cases, as described in https://lists.apache.org/thread.html/08af5d8247c316f46f4dc1ec93173721f684109b8a9d41a4431558ec@%3Cdev.beam.apache.org%3E As noted in that thread, they may reappear in the future as a more general shorthand for "side-output + combine", but they need to address things like windowing, and latter use within the pipeline to be really useful in that role. Within PAssert: They may be replaced with either Metrics (if possible) or with an explicit side-output + combine which should be semantically equivalent. > Port PAssert away from Aggregators > -- > > Key: BEAM-1148 > URL: https://issues.apache.org/jira/browse/BEAM-1148 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core >Reporter: Kenneth Knowles > > One step in the removal of Aggregators (in favor of Metrics) is to remove our > reliance on them for PAssert checking. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-1148) Port PAssert away from Aggregators
[ https://issues.apache.org/jira/browse/BEAM-1148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748240#comment-15748240 ] Aljoscha Krettek commented on BEAM-1148: Just out of curiosity, what are they going to be replaced with? > Port PAssert away from Aggregators > -- > > Key: BEAM-1148 > URL: https://issues.apache.org/jira/browse/BEAM-1148 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core >Reporter: Kenneth Knowles > > One step in the removal of Aggregators (in favor of Metrics) is to remove our > reliance on them for PAssert checking. -- This message was sent by Atlassian JIRA (v6.3.4#6332)