[jira] [Commented] (BEAM-525) Verify that ParDo with multiple outputs with tags un declared in with_outputs() work

2016-10-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616085#comment-15616085
 ] 

ASF GitHub Bot commented on BEAM-525:
-

Github user pabloem closed the pull request at:

https://github.com/apache/incubator-beam/pull/1209


> Verify that ParDo with multiple outputs with tags un declared in 
> with_outputs() work 
> -
>
> Key: BEAM-525
> URL: https://issues.apache.org/jira/browse/BEAM-525
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Ahmet Altay
>Priority: Minor
>
> test_undeclared_side_outputs was failing (when last checked) under certain 
> conditions:
> See this TODO:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/dataflow_test.py#L202
> This is probably not failing any more but it needs to be verified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-525) Verify that ParDo with multiple outputs with tags un declared in with_outputs() work

2016-10-27 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612466#comment-15612466
 ] 

ASF GitHub Bot commented on BEAM-525:
-

GitHub user pabloem opened a pull request:

https://github.com/apache/incubator-beam/pull/1209

[BEAM-525] Remove superflous TODO in dataflow_test

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [x] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [x] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pabloem/incubator-beam remove-dftst-todo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1209


commit 34f6236ad3536cc69dec01d02f0b83218be56d42
Author: Pablo 
Date:   2016-10-27T16:38:59Z

Removing superfluous TODO after unittest is passing




> Verify that ParDo with multiple outputs with tags un declared in 
> with_outputs() work 
> -
>
> Key: BEAM-525
> URL: https://issues.apache.org/jira/browse/BEAM-525
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Ahmet Altay
>Priority: Minor
>
> test_undeclared_side_outputs was failing (when last checked) under certain 
> conditions:
> See this TODO:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/dataflow_test.py#L202
> This is probably not failing any more but it needs to be verified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-525) Verify that ParDo with multiple outputs with tags un declared in with_outputs() work

2016-10-26 Thread Ahmet Altay (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610266#comment-15610266
 ] 

Ahmet Altay commented on BEAM-525:
--

Looks like the checks in that TODO are already part of the test. Yes, let's 
close this issue but first remove that TODO from the code.

> Verify that ParDo with multiple outputs with tags un declared in 
> with_outputs() work 
> -
>
> Key: BEAM-525
> URL: https://issues.apache.org/jira/browse/BEAM-525
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Ahmet Altay
>Priority: Minor
>
> test_undeclared_side_outputs was failing (when last checked) under certain 
> conditions:
> See this TODO:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/dataflow_test.py#L202
> This is probably not failing any more but it needs to be verified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-525) Verify that ParDo with multiple outputs with tags un declared in with_outputs() work

2016-10-26 Thread Pablo Estrada (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15610037#comment-15610037
 ] 

Pablo Estrada commented on BEAM-525:


This test runs without failing - should we close this? Or if you recall which 
are the conditions under which it fails, I can take a look : )

> Verify that ParDo with multiple outputs with tags un declared in 
> with_outputs() work 
> -
>
> Key: BEAM-525
> URL: https://issues.apache.org/jira/browse/BEAM-525
> Project: Beam
>  Issue Type: Bug
>  Components: sdk-py
>Reporter: Ahmet Altay
>Priority: Minor
>
> test_undeclared_side_outputs was failing (when last checked) under certain 
> conditions:
> See this TODO:
> https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/dataflow_test.py#L202
> This is probably not failing any more but it needs to be verified.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)