[jira] [Commented] (BEAM-593) Support cancel() and waitUntilFinish() in FlinkRunnerResult

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15571724#comment-15571724
 ] 

ASF GitHub Bot commented on BEAM-593:
-

GitHub user mxm opened a pull request:

https://github.com/apache/incubator-beam/pull/1093

[BEAM-593] avoid throwing Exception in waitUntilFinish

The current implementation of Flink's `PipelineResult` assumes that the 
pipeline has already been processed. Hence, we can return State.Done when 
`wailUntilFinish()` is called.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mxm/incubator-beam BEAM-593

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/1093.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1093


commit c4b78841a82951b5f7c3e1c7763e078317bb3a2f
Author: Maximilian Michels 
Date:   2016-10-13T12:01:06Z

[BEAM-593] avoid throwing Exception in waitUntilFinish

The current implementation of Flink's PipelineResult assumes that the
pipeline has already been processed. Hence, we can return State.Done
when wailUntilFinished is called.




> Support cancel() and waitUntilFinish() in FlinkRunnerResult
> ---
>
> Key: BEAM-593
> URL: https://issues.apache.org/jira/browse/BEAM-593
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-flink
>Reporter: Pei He
>
> We introduced both functions to PipelineResult.
> Currently, both of them throw UnsupportedOperationException in Flink runner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-593) Support cancel() and waitUntilFinish() in FlinkRunnerResult

[Maximilian Michels (JIRA)]

[ 
https://issues.apache.org/jira/browse/BEAM-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15467548#comment-15467548
 ] 

Maximilian Michels commented on BEAM-593:
-

+1 These need to be supported. We need to change the execution behavior which 
defaults to blocking upon {{Pipeline.run()}}.

> Support cancel() and waitUntilFinish() in FlinkRunnerResult
> ---
>
> Key: BEAM-593
> URL: https://issues.apache.org/jira/browse/BEAM-593
> Project: Beam
>  Issue Type: New Feature
>  Components: runner-flink
>Reporter: Pei He
>
> We introduced both functions to PipelineResult.
> Currently, both of them throw UnsupportedOperationException in Flink runner.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)