[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-17 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15583904#comment-15583904
 ] 

ASF GitHub Bot commented on BEAM-697:
-

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-beam/pull/


> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-14 Thread Jeffrey Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576406#comment-15576406
 ] 

Jeffrey Payne commented on BEAM-697:


Submitted fix in PR https://github.com/apache/incubator-beam/pull/

> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-14 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576401#comment-15576401
 ] 

ASF GitHub Bot commented on BEAM-697:
-

GitHub user jeffkpayne opened a pull request:

https://github.com/apache/incubator-beam/pull/

[BEAM-697] TextIO.Write.Bound.withHeader() and withFooter() now use t…

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

 - [ ] Make sure the PR title is formatted like:
   `[BEAM-] Description of pull request`
 - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
   Travis-CI on your fork and ensure the whole test matrix passes).
 - [ ] Replace `` in the title with the actual Jira issue
   number, if there is one.
 - [ ] If this contribution is large, please file an Apache
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.txt).

---

…he current value of validate for the returned Bound instance, added 
supporting tests

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bomboradata/incubator-beam BEAM-697-fix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-beam/pull/.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #


commit 5cc0441d1e2e57be6a2b7c80d4c477657f004104
Author: Jeffrey Scott Keone Payne 
Date:   2016-10-14T20:33:16Z

[BEAM-697] TextIO.Write.Bound.withHeader() and withFooter() now use the 
current value of validate for the returned Bound instance, added supporting 
tests




> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-14 Thread Jeffrey Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15575414#comment-15575414
 ] 

Jeffrey Payne commented on BEAM-697:


Will do!

> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-13 Thread Daniel Halperin (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574335#comment-15574335
 ] 

Daniel Halperin commented on BEAM-697:
--

Thanks for this. Mirroring from discussion on that PR, prefer to separate out 
this (awesome, welcome) fix as its own PR.

> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-01 Thread Jeffrey Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15539503#comment-15539503
 ] 

Jeffrey Payne commented on BEAM-697:


The fix for this is included in 
https://github.com/apache/incubator-beam/pull/1027, pushed a few minute ago, 
FYI.  I added two unit tests to cover the two specific use cases.

> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (BEAM-697) TextIO.Write.Bound.withHeader() and withFooter() do not use the current value of validate for the returned Bound instance

2016-10-01 Thread Jeffrey Payne (JIRA) 

[ 
https://issues.apache.org/jira/browse/BEAM-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538889#comment-15538889
 ] 

Jeffrey Payne commented on BEAM-697:


[~frances], let me know if you want me to *not* include the trivial fix for 
this in my forthcoming changes for BEAM-55 in 
https://github.com/apache/incubator-beam/pull/1027.  Thanks.

> TextIO.Write.Bound.withHeader() and withFooter() do not use the current value 
> of validate for the returned Bound instance
> -
>
> Key: BEAM-697
> URL: https://issues.apache.org/jira/browse/BEAM-697
> Project: Beam
>  Issue Type: Bug
>  Components: beam-model
>Affects Versions: 0.2.0-incubating, 0.3.0-incubating
>Reporter: Jeffrey Payne
>Assignee: Frances Perry
>Priority: Minor
> Fix For: 0.3.0-incubating
>
>
> {{TextIO.Write.Bound.withHeader()}} and {{TextIO.Write.Bound.withFooter()}} 
> both pass a literal value of {{false}} to the constructor's {{validate}} 
> parameter for the returned {{Bound}} instance.  This could, obviously, lead 
> to unintended behavior wrt pipeline validation.  Looks like a simple copy and 
> paste error from {{TextIO.Write.Bound.withoutValidation()}} :)
> I'm about to push another iteration for a PR for BEAM-55 and have included 
> the *trivial* fix for this bug it in that set of changes.  Creating this in 
> case my PR is not accepted right away.  Please close if this issue is wholly 
> unnecessary.  Thanks!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)