[jira] [Updated] (BEAM-520) Update Python SDK example tests to use assert_that
[ https://issues.apache.org/jira/browse/BEAM-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Altay updated BEAM-520: - Assignee: Frances Perry > Update Python SDK example tests to use assert_that > -- > > Key: BEAM-520 > URL: https://issues.apache.org/jira/browse/BEAM-520 > Project: Beam > Issue Type: Improvement > Components: sdk-py >Reporter: Ahmet Altay >Assignee: Frances Perry >Priority: Minor > Labels: starter > > Most of our examples use assert_that to test examples: > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/complete/autocomplete_test.py#L38 > Some of our examples use this pattern: > 1) Create a path(s) > 2) Construct fake command line arguments using these paths > 3) Construct an argparse object to parse these flags > 4) Do the (often trivial logic) > 5) Write to a file > 6) Manually open and read the file > 7) Compare results. > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py > As well as being cumbersome, this obscures the core of what is being > illustrated and tested. As many as possible tests should be updated to use > assert_that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (BEAM-520) Update Python SDK example tests to use assert_that
[ https://issues.apache.org/jira/browse/BEAM-520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmet Altay updated BEAM-520: - Assignee: (was: Frances Perry) > Update Python SDK example tests to use assert_that > -- > > Key: BEAM-520 > URL: https://issues.apache.org/jira/browse/BEAM-520 > Project: Beam > Issue Type: Improvement > Components: sdk-py >Reporter: Ahmet Altay >Priority: Minor > Labels: starter > > Most of our examples use assert_that to test examples: > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/complete/autocomplete_test.py#L38 > Some of our examples use this pattern: > 1) Create a path(s) > 2) Construct fake command line arguments using these paths > 3) Construct an argparse object to parse these flags > 4) Do the (often trivial logic) > 5) Write to a file > 6) Manually open and read the file > 7) Compare results. > https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py > As well as being cumbersome, this obscures the core of what is being > illustrated and tested. As many as possible tests should be updated to use > assert_that. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
