[GitHub] [bookkeeper] wenbingshen commented on pull request #3652: Add num not adhering placement ledgers replicated metric for ReplicationWorker

wenbingshen commented on PR #3652: URL: https://github.com/apache/bookkeeper/pull/3652#issuecomment-1447709757 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3652: Add num not adhering placement ledgers replicated metric for ReplicationWorker

codecov-commenter commented on PR #3652: URL: https://github.com/apache/bookkeeper/pull/3652#issuecomment-1447685715 #

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3819: Update testcontainers to last version to support m1

codecov-commenter commented on PR #3819: URL: https://github.com/apache/bookkeeper/pull/3819#issuecomment-1447529217 #

[GitHub] [bookkeeper] Shoothzj closed pull request #3819: Update testcontainers to last version to support m1

Shoothzj closed pull request #3819: Update testcontainers to last version to support m1 URL: https://github.com/apache/bookkeeper/pull/3819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3824: Use JNI directly for posix_fadvise

hangc0276 commented on PR #3824: URL: https://github.com/apache/bookkeeper/pull/3824#issuecomment-1447508654 Please fix the failed check: ``` Error: /home/runner/work/bookkeeper/bookkeeper/bookkeeper-server/src/main/java/org/apache/bookkeeper/util/PageCacheUtil.java:37:28: Name

[GitHub] [bookkeeper] Reidddddd commented on pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1447490556 Failed UTs seem related, working on -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [bookkeeper] merlimat opened a new pull request, #3824: Use JNI directly for posix_fadvise

merlimat opened a new pull request, #3824: URL: https://github.com/apache/bookkeeper/pull/3824 ### Motivation For calling `posix_fadvise`, we are using JNA which is a wrapper on top of JNI. While JNA is convenient because it's dynamically creating a stub for accessing native

[bookkeeper] branch master updated: Fix: typo for ledger-metadata param: restorefromfile (#3823)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new 0ca4fe2697 Fix: typo for ledger-metadata

[GitHub] [bookkeeper] merlimat merged pull request #3823: Fix: typo for ledger-metadata param: restorefromfile

merlimat merged PR #3823: URL: https://github.com/apache/bookkeeper/pull/3823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated: Support update ledger metadata option bk-cli (#3821)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new e0ee708269 Support update ledger metadata

[GitHub] [bookkeeper] merlimat merged pull request #3822: Fix: bookie-shell ledger-metadata usage with correct param

merlimat merged PR #3822: URL: https://github.com/apache/bookkeeper/pull/3822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated (e0ee708269 -> ade30bda19)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from e0ee708269 Support update ledger metadata option bk-cli (#3821) add ade30bda19 Fix: bookie-shell

[GitHub] [bookkeeper] merlimat merged pull request #3821: Support update ledger metadata option bk-cli

merlimat merged PR #3821: URL: https://github.com/apache/bookkeeper/pull/3821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3821: Support update ledger metadata option bk-cli

codecov-commenter commented on PR #3821: URL: https://github.com/apache/bookkeeper/pull/3821#issuecomment-1447061604 #

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3823: Fix: typo for ledger-metadata param: restorefromfile

codecov-commenter commented on PR #3823: URL: https://github.com/apache/bookkeeper/pull/3823#issuecomment-1447052173 #

[GitHub] [bookkeeper] merlimat merged pull request #3820: Remove compiling with `-Werror` to support Java 19

merlimat merged PR #3820: URL: https://github.com/apache/bookkeeper/pull/3820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated (c389b96f12 -> 284cf9611a)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from c389b96f12 Speed up shutdown in test cases (#3809) add 284cf9611a Remove compiling with `-Werror` to support

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3822: Fix: bookie-shell ledger-metadata usage with correct param

codecov-commenter commented on PR #3822: URL: https://github.com/apache/bookkeeper/pull/3822#issuecomment-1447031273 #

[GitHub] [bookkeeper] rdhabalia opened a new pull request, #3823: Fix: typo for ledger-metadata param: restorefromfile

rdhabalia opened a new pull request, #3823: URL: https://github.com/apache/bookkeeper/pull/3823 ### Motivation https://github.com/apache/bookkeeper/pull/2019 has introduced a typo in ledgerMetadata bk-shell command which checks invalid input param `restorefromefile` instead of

[GitHub] [bookkeeper] rdhabalia opened a new pull request, #3822: Fix: bookie-shell ledger-metadata usage with correct param

rdhabalia opened a new pull request, #3822: URL: https://github.com/apache/bookkeeper/pull/3822 ### Motivation `./bin/bookkeeper shell ledgermetadata` usage is showing incorrect params `dump-to-file` , `restore-from` to user while executing the command. ### Changes Fix

[GitHub] [bookkeeper] rdhabalia opened a new pull request, #3821: Support update ledger metadata option bk-cli

rdhabalia opened a new pull request, #3821: URL: https://github.com/apache/bookkeeper/pull/3821 ### Motivation Bk-CLI api supports creating ledger metadata from the metadata binary payload-file but it doesn't support updating metadata for existing ledger which will require some time

[bookkeeper] branch master updated: Speed up shutdown in test cases (#3809)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new c389b96f12 Speed up shutdown in test cases

[GitHub] [bookkeeper] merlimat merged pull request #3809: Speed up shutdown in test cases

merlimat merged PR #3809: URL: https://github.com/apache/bookkeeper/pull/3809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] merlimat closed issue #3808: [Test] BookKeeperAdminTest cost more than 20min in CI

merlimat closed issue #3808: [Test] BookKeeperAdminTest cost more than 20min in CI URL: https://github.com/apache/bookkeeper/issues/3808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3820: Remove compiling with `-Werror` to support Java 19

codecov-commenter commented on PR #3820: URL: https://github.com/apache/bookkeeper/pull/3820#issuecomment-1446669859 #

[GitHub] [bookkeeper] merlimat opened a new pull request, #3820: Remove compiling with `-Werror` to support Java 19

merlimat opened a new pull request, #3820: URL: https://github.com/apache/bookkeeper/pull/3820 ### Motivation Building BK with Java 19 fails because there is a deprecation warning and it's being treated as an error. In a few places, we are using `Thread.getId()` which has been

[GitHub] [bookkeeper] Shoothzj commented on pull request #3819: Update testcontainers to last version to support m1

Shoothzj commented on PR #3819: URL: https://github.com/apache/bookkeeper/pull/3819#issuecomment-1446565355 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3818: [improvement] Delay all audit task when have a already delayed bookie check task

codecov-commenter commented on PR #3818: URL: https://github.com/apache/bookkeeper/pull/3818#issuecomment-1446423213 #

[GitHub] [bookkeeper] Shoothzj opened a new pull request, #3819: Update testcontainers to last version to support m1

Shoothzj opened a new pull request, #3819: URL: https://github.com/apache/bookkeeper/pull/3819 ### Motivation Update testcontainers to last version to support m1. Tested on my laptop. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3813: [Bug] Always one orphan ledger is created

codecov-commenter commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1446416331 #

[GitHub] [bookkeeper] Reidddddd commented on pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1446369283 I want to have a whole review about the Phase's state machine and refine it after this quick fix. What do you think of the idea -- This is an automated message from the Apache

[GitHub] [bookkeeper] Reidddddd commented on pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1446364278 New commit use positive condition check as review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [bookkeeper] Nicklee007 commented on pull request #3804: fix mailing-lists dead links

Nicklee007 commented on PR #3804: URL: https://github.com/apache/bookkeeper/pull/3804#issuecomment-1446277554 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3818: [improvement] Delay all audit task when have a already delayed bookie check task

wenbingshen opened a new pull request, #3818: URL: https://github.com/apache/bookkeeper/pull/3818 ### Motivation Fixes #3817 For details, see: #3817 ### Changes When there is an `auditTask` during the `lostBookieRecoveryDelay` delay, other detection tasks

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3816: Upgrade Netty to 4.1.89.Final

codecov-commenter commented on PR #3816: URL: https://github.com/apache/bookkeeper/pull/3816#issuecomment-1446240850 #

[GitHub] [bookkeeper] wenbingshen opened a new issue, #3817: Auditor replicas check task will perform check and recovery during Bookie lost in lostBookieRecoveryDelay

wenbingshen opened a new issue, #3817: URL: https://github.com/apache/bookkeeper/issues/3817 ***Describe the bug*** When we were on vacation, a bookie node rejoined the cluster after shaking, and the bookie came back online at the lostBookieRecoveryDelay time, and the Auditor

[GitHub] [bookkeeper] lhotari opened a new pull request, #3816: Upgrade Netty to 4.1.89.Final

lhotari opened a new pull request, #3816: URL: https://github.com/apache/bookkeeper/pull/3816 ### Motivation - Netty upgrade contains relevant Netty bug fixes ### Changes - Upgrade Netty to 4.1.89.Final - Also upgraded Netty's io_uring support to a compatible

[bookkeeper] branch master updated (1e02853485 -> 6f09c60d2c)

This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from 1e02853485 Avoid thread-local state when computing CRCs (#3811) add 6f09c60d2c Upgrade lombok to 1.18.26

[GitHub] [bookkeeper] Shoothzj merged pull request #3814: Upgrade lombok to 1.18.26

Shoothzj merged PR #3814: URL: https://github.com/apache/bookkeeper/pull/3814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] hangc0276 commented on pull request #3802: Add trigger entry location index rocksDB compact REST API

hangc0276 commented on PR #3802: URL: https://github.com/apache/bookkeeper/pull/3802#issuecomment-1446117240 @Nicklee007 Please rebase the master, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on pull request #3804: fix mailing-lists dead links

hangc0276 commented on PR #3804: URL: https://github.com/apache/bookkeeper/pull/3804#issuecomment-1446116024 Please rebase the master, thanks @Nicklee007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on pull request #3809: Speed up shutdown in test cases

hangc0276 commented on PR #3809: URL: https://github.com/apache/bookkeeper/pull/3809#issuecomment-1446098543 After applying this change, the `BookKeeperAdminTest` cost time was reduced from `1,462.832` s to `294.611` s ``` [INFO] Running

[GitHub] [bookkeeper] hangc0276 commented on pull request #3809: Speed up shutdown in test cases

hangc0276 commented on PR #3809: URL: https://github.com/apache/bookkeeper/pull/3809#issuecomment-1446088148 > There are many failure on CI > > While I support this patch, I think we should understand why there are so many failure > > I would like to not add new flakyness

[GitHub] [bookkeeper] hangc0276 opened a new issue, #3815: [Test] Unit tests zookeeper client keeps print Connection refused

hangc0276 opened a new issue, #3815: URL: https://github.com/apache/bookkeeper/issues/3815 ### Description When I run BookKeeper unit tests, such as BookieDecommissionTest#testDecommissionBookie, the zookeeper client always print the following exceptions when connecting to the Zookeeper

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3814: Upgrade lombok to 1.18.26

codecov-commenter commented on PR #3814: URL: https://github.com/apache/bookkeeper/pull/3814#issuecomment-1446010915 #

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3814: Upgrade lombok to 1.18.26

hangc0276 opened a new pull request, #3814: URL: https://github.com/apache/bookkeeper/pull/3814 ### Modifications Upgrade Lombok to 1.18.26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] Reidddddd commented on a diff in pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on code in PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#discussion_r1118461347 ## stream/distributedlog/core/src/main/java/org/apache/distributedlog/bk/SimpleLedgerAllocator.java: ## @@ -382,7 +382,9 @@ private synchronized void

[GitHub] [bookkeeper] Reidddddd commented on a diff in pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on code in PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#discussion_r1118461347 ## stream/distributedlog/core/src/main/java/org/apache/distributedlog/bk/SimpleLedgerAllocator.java: ## @@ -382,7 +382,9 @@ private synchronized void

[GitHub] [bookkeeper] Nicklee007 commented on pull request #3773: [improve] Let the replication worker can rerplicate the fresh ledgers at first.

Nicklee007 commented on PR #3773: URL: https://github.com/apache/bookkeeper/pull/3773#issuecomment-1445915568 > I have one concern about the sort. If we have multiple replication workers, and each replication worker sorts the ledgers before getting the target ledger to replicate. Would

[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3813: [Bug] Always one orphan ledger is created

eolivelli commented on code in PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#discussion_r1118406096 ## stream/distributedlog/core/src/main/java/org/apache/distributedlog/bk/SimpleLedgerAllocator.java: ## @@ -382,7 +382,9 @@ private synchronized void

[GitHub] [bookkeeper] Reidddddd commented on pull request #3813: [Bug] Always one orphan ledger is created

Reidd commented on PR #3813: URL: https://github.com/apache/bookkeeper/pull/3813#issuecomment-1445872098 I described the root cause in https://github.com/apache/bookkeeper/issues/3812 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[bookkeeper] branch master updated: Avoid thread-local state when computing CRCs (#3811)

This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new 1e02853485 Avoid thread-local state when

[GitHub] [bookkeeper] hangc0276 merged pull request #3811: Avoid thread-local state when computing CRCs

hangc0276 merged PR #3811: URL: https://github.com/apache/bookkeeper/pull/3811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: