[GitHub] [bookkeeper] codecov-commenter commented on pull request #3841: Fix website deploy build failed

2023-03-05 Thread via GitHub
codecov-commenter commented on PR #3841: URL: https://github.com/apache/bookkeeper/pull/3841#issuecomment-1455620462 #

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3841: Fix website deploy build failed

2023-03-05 Thread via GitHub
hangc0276 opened a new pull request, #3841: URL: https://github.com/apache/bookkeeper/pull/3841 ### Motivation Website deployment build failed https://github.com/apache/bookkeeper/actions/runs/4340797094/jobs/7579680220 It may be caused by the maven 3.9.0 bug

[GitHub] [bookkeeper] wenbingshen commented on pull request #3833: [improve] Enhance LedgerFragment toString method

2023-03-05 Thread via GitHub
wenbingshen commented on PR #3833: URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1455569591 @horizonzy @hangc0276 @zymap Could you help take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[bookkeeper] branch master updated (3199fbe4d6 -> 3844bf128c)

2023-03-05 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from 3199fbe4d6 Add directIO entry logger settings documents (#3789) add 3844bf128c Make RrocksDB checksum type

[GitHub] [bookkeeper] hangc0276 closed issue #3734: RocksDB: segfault in org.rocksdb.WriteBatch::delete called from org.apache.bookkeeper.bookie.storage.ldb.EntryLocationIndex#removeOffsetFromDeletedL

2023-03-05 Thread via GitHub
hangc0276 closed issue #3734: RocksDB: segfault in org.rocksdb.WriteBatch::delete called from org.apache.bookkeeper.bookie.storage.ldb.EntryLocationIndex#removeOffsetFromDeletedLedgers URL: https://github.com/apache/bookkeeper/issues/3734 -- This is an automated message from the Apache Git

[GitHub] [bookkeeper] hangc0276 merged pull request #3793: Make RrocksDB checksum type configurable

2023-03-05 Thread via GitHub
hangc0276 merged PR #3793: URL: https://github.com/apache/bookkeeper/pull/3793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3793: Make RrocksDB checksum type configurable

2023-03-05 Thread via GitHub
hangc0276 commented on code in PR #3793: URL: https://github.com/apache/bookkeeper/pull/3793#discussion_r1126008070 ## bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/storage/ldb/KeyValueStorageRocksDBTest.java: ## @@ -78,4 +80,38 @@ public void

[bookkeeper] branch master updated: Add directIO entry logger settings documents (#3789)

2023-03-05 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new 3199fbe4d6 Add directIO entry logger

[GitHub] [bookkeeper] hangc0276 merged pull request #3789: Add directIO entry logger settings documents

2023-03-05 Thread via GitHub
hangc0276 merged PR #3789: URL: https://github.com/apache/bookkeeper/pull/3789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [bookkeeper] codecov-commenter commented on pull request #3833: [improve] Enhance LedgerFragment toString method

2023-03-05 Thread via GitHub
codecov-commenter commented on PR #3833: URL: https://github.com/apache/bookkeeper/pull/3833#issuecomment-1455501217 #

[GitHub] [bookkeeper] StevenLuMT closed pull request #3840: [refactor] [server] Use ReferenceCountUtil.release instead of ReferenceCountUtil.safeRelease

2023-03-05 Thread via GitHub
StevenLuMT closed pull request #3840: [refactor] [server] Use ReferenceCountUtil.release instead of ReferenceCountUtil.safeRelease URL: https://github.com/apache/bookkeeper/pull/3840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [bookkeeper] StevenLuMT commented on pull request #3796: BP61: revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

2023-03-05 Thread via GitHub
StevenLuMT commented on PR #3796: URL: https://github.com/apache/bookkeeper/pull/3796#issuecomment-1455476148 > Fix #3792 why not directly replace ReferenceCountUtil.safeRelease() with ReferenceCountUtil.release? #3840 > >

[GitHub] [bookkeeper] StevenLuMT opened a new pull request, #3840: [refactor] [server] Use ReferenceCountUtil.release instead of ReferenceCountUtil.safeRelease

2023-03-05 Thread via GitHub
StevenLuMT opened a new pull request, #3840: URL: https://github.com/apache/bookkeeper/pull/3840 Fix #3792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [bookkeeper] hangc0276 commented on pull request #3796: BP61: revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()

2023-03-05 Thread via GitHub
hangc0276 commented on PR #3796: URL: https://github.com/apache/bookkeeper/pull/3796#issuecomment-1455428997 > https://mail.google.com/mail/u/0/#inbox/FMfcgzGrcjQBvslxtJLpRNJfqCwknmpg -1 (non-binding) for new BP-61 : > > 1. I think no need to revert 12 PRs to refactor the ByteBuf

[GitHub] [bookkeeper] hangc0276 closed pull request #2871: add bookie expand or shrink directories operation guide

2023-03-05 Thread via GitHub
hangc0276 closed pull request #2871: add bookie expand or shrink directories operation guide URL: https://github.com/apache/bookkeeper/pull/2871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 closed pull request #2633: add flag to control whether basic metrics expose to prometheus or not

2023-03-05 Thread via GitHub
hangc0276 closed pull request #2633: add flag to control whether basic metrics expose to prometheus or not URL: https://github.com/apache/bookkeeper/pull/2633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3838: Added BatchedArrayBlockingQueue

2023-03-05 Thread via GitHub
hangc0276 commented on code in PR #3838: URL: https://github.com/apache/bookkeeper/pull/3838#discussion_r1125774721 ## bookkeeper-common/src/main/java/org/apache/bookkeeper/common/collections/BatchedArrayBlockingQueue.java: ## @@ -0,0 +1,409 @@ +/* + * + * Licensed to the

[bookkeeper] branch master updated: Simplified the logic for ForceWriteThread after we introduced queue.drainTo() (#3830)

2023-03-05 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new 128c52eeff Simplified the logic for

[GitHub] [bookkeeper] hangc0276 merged pull request #3830: Simplified the logic for ForceWriteThread after we introduced queue.drainTo()

2023-03-05 Thread via GitHub
hangc0276 merged PR #3830: URL: https://github.com/apache/bookkeeper/pull/3830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated: Pass BookieRequestHandler instead of Channel to the request processors (#3835)

2023-03-05 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new dfde3d6836 Pass BookieRequestHandler

[GitHub] [bookkeeper] merlimat merged pull request #3835: Pass BookieRequestHandler instead of Channel to the request processors

2023-03-05 Thread via GitHub
merlimat merged PR #3835: URL: https://github.com/apache/bookkeeper/pull/3835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: