[GitHub] [bookkeeper] zymap commented on a diff in pull request #3962: [fix] Fix wrong key for getHttpServerTrustStorePassword

2023-05-22 Thread via GitHub
zymap commented on code in PR #3962: URL: https://github.com/apache/bookkeeper/pull/3962#discussion_r1201405682 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java: ## @@ -3698,7 +3700,7 @@ public ServerConfiguration

[GitHub] [bookkeeper] merlimat merged pull request #3959: Avoid compaction to trigger extra flushes DbLedgerStorage

2023-05-22 Thread via GitHub
merlimat merged PR #3959: URL: https://github.com/apache/bookkeeper/pull/3959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[bookkeeper] branch master updated: Avoid compaction to trigger extra flushes DbLedgerStorage (#3959)

2023-05-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new c924cfeb50 Avoid compaction to trigger

[GitHub] [bookkeeper] wenbingshen opened a new pull request, #3966: [fix] Clear channel when channelInactive

2023-05-22 Thread via GitHub
wenbingshen opened a new pull request, #3966: URL: https://github.com/apache/bookkeeper/pull/3966 ### Motivation I am stopping a pulsar broker, and I observed a lot of the following logs in the broker log: 17:48:35.894 [shutdown-thread-43-1] INFO

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3956: Support skip invalid journal record in replying journal stage

2023-05-22 Thread via GitHub
hangc0276 commented on code in PR #3956: URL: https://github.com/apache/bookkeeper/pull/3956#discussion_r1200244274 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java: ## @@ -4010,6 +4012,25 @@ public boolean

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3956: Support skip invalid journal record in replying journal stage

2023-05-22 Thread via GitHub
hangc0276 commented on code in PR #3956: URL: https://github.com/apache/bookkeeper/pull/3956#discussion_r1200242610 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java: ## @@ -827,22 +828,32 @@ public long scanJournal(long journalId, long journalPos,

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3329: Fix data lost when configured multiple ledger directories

2023-05-22 Thread via GitHub
hangc0276 commented on code in PR #3329: URL: https://github.com/apache/bookkeeper/pull/3329#discussion_r1200075769 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieImpl.java: ## @@ -872,6 +869,9 @@ int shutdown(int exitCode) { // Shutdown