Re: [PR] Fix bookie process still alive when bookie startup is not successful and shutdown [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 closed pull request #4111: Fix bookie process still alive when bookie startup is not successful and shutdown URL: https://github.com/apache/bookkeeper/pull/4111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] ReadLedgerCommand can't get lastEntry when specifying the ledger rang… [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 commented on PR #4149: URL: https://github.com/apache/bookkeeper/pull/4149#issuecomment-1955968093 The test failed with timeout

[PR] Fix getHosts by ip [bookkeeper]

2024-02-20 Thread via GitHub
nodece opened a new pull request, #4217: URL: https://github.com/apache/bookkeeper/pull/4217 ### Motivation - The PTR result will end with a `.`, we need to trim that, please see https://datatracker.ietf.org/doc/html/rfc1035#autoid-37 - In testing, we use the loopback net

Re: [PR] Fixed merge conflict [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 commented on PR #4216: URL: https://github.com/apache/bookkeeper/pull/4216#issuecomment-1955917949 This PR https://github.com/apache/bookkeeper/pull/4215 already resolved the merge conflict. -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] Fixed merge conflict [bookkeeper]

2024-02-20 Thread via GitHub
merlimat opened a new pull request, #4216: URL: https://github.com/apache/bookkeeper/pull/4216 Descriptions of the changes in this PR: ### Motivation (Explain: why you're making that change, what is the problem you're trying to solve) ### Changes

Re: [PR] [improve] Support specifying multiple journalDirs for the bookie server start cmd options [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 commented on code in PR #4181: URL: https://github.com/apache/bookkeeper/pull/4181#discussion_r1496875881 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/server/Main.java: ## @@ -165,9 +169,12 @@ private static ServerConfiguration parseArgs(String[] args)

(bookkeeper) branch master updated: Remove duplicate setBatchReadEnabled (#4215)

2024-02-20 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new a79a4e21e8 Remove duplicate

Re: [PR] Remove duplicate setBatchReadEnabled [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 merged PR #4215: URL: https://github.com/apache/bookkeeper/pull/4215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Remove duplicate setBatchReadEnabled [bookkeeper]

2024-02-20 Thread via GitHub
nodece opened a new pull request, #4215: URL: https://github.com/apache/bookkeeper/pull/4215 ### Motivation `setBatchReadEnabled` is duplicated, which breaks the compilation. ### Changes Remove the duplicated method. -- This is an automated message from the Apache Git

(bookkeeper) branch master updated: [improve] fix doc & fix listfilesondisc cmd description (#4184)

2024-02-20 Thread chenhang
This is an automated email from the ASF dual-hosted git repository. chenhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new e25c5487ae [improve] fix doc & fix

Re: [PR] [improve] fix doc & fix listfilesondisc cmd description [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 merged PR #4184: URL: https://github.com/apache/bookkeeper/pull/4184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] log error when ReadEntryProcessor IOException [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 commented on code in PR #4199: URL: https://github.com/apache/bookkeeper/pull/4199#discussion_r1496806910 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/ReadEntryProcessor.java: ## @@ -105,9 +105,7 @@ protected void processPacket() { }

Re: [PR] Issue 2161: set metrics endpoint content-type [bookkeeper]

2024-02-20 Thread via GitHub
hangc0276 commented on code in PR #4208: URL: https://github.com/apache/bookkeeper/pull/4208#discussion_r1496785687 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/MetricsService.java: ## @@ -65,6 +67,7 @@ public HttpServiceResponse

(bookkeeper) branch dependabot/maven/org.apache.commons-commons-compress-1.26.0 created (now 2607ee6f38)

2024-02-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.commons-commons-compress-1.26.0 in repository https://gitbox.apache.org/repos/asf/bookkeeper.git at 2607ee6f38 Bump org.apache.commons:commons-compress

[PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [bookkeeper]

2024-02-20 Thread via GitHub
dependabot[bot] opened a new pull request, #4214: URL: https://github.com/apache/bookkeeper/pull/4214 Bumps org.apache.commons:commons-compress from 1.21 to 1.26.0. [![Dependabot compatibility

Re: [PR] Use mockito instead of powermock [bookkeeper]

2024-02-20 Thread via GitHub
lhotari commented on PR #4212: URL: https://github.com/apache/bookkeeper/pull/4212#issuecomment-1955068797 @nodece the next step would be to upgrade Mockito to 4.11. That's the last version that supports Java 8. Would you like to handle it. There are some minor breaking changes in Mockito

Re: [PR] Use mockito instead of powermock [bookkeeper]

2024-02-20 Thread via GitHub
lhotari commented on PR #4212: URL: https://github.com/apache/bookkeeper/pull/4212#issuecomment-1954932175 Great job @nodece -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

(bookkeeper) branch master updated: [BP-62] Add more test for Bookkeeper. (#4210)

2024-02-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new eb27e6ed3c [BP-62] Add more test for

Re: [PR] [BP-62] Add more test for Bookkeeper. [bookkeeper]

2024-02-20 Thread via GitHub
merlimat merged PR #4210: URL: https://github.com/apache/bookkeeper/pull/4210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(bookkeeper) branch master updated (ee56a953fe -> 978414fdbf)

2024-02-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git from ee56a953fe Use mockito instead of powermock (#4212) add 978414fdbf Add

Re: [PR] Add `InetAddress.getLocalHost().getCanonicalHostName()` for TestRackawareEnsemblePlacementPolicy#updateMyRack. [bookkeeper]

2024-02-20 Thread via GitHub
merlimat merged PR #4213: URL: https://github.com/apache/bookkeeper/pull/4213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(bookkeeper) branch master updated: Use mockito instead of powermock (#4212)

2024-02-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new ee56a953fe Use mockito instead of powermock

Re: [PR] Use mockito instead of powermock [bookkeeper]

2024-02-20 Thread via GitHub
merlimat merged PR #4212: URL: https://github.com/apache/bookkeeper/pull/4212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] AutoRecovery supports batch read [bookkeeper]

2024-02-20 Thread via GitHub
merlimat merged PR #4211: URL: https://github.com/apache/bookkeeper/pull/4211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(bookkeeper) branch master updated: AutoRecovery supports batch read (#4211)

2024-02-20 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new ef4ce1385f AutoRecovery supports batch read

Re: [PR] Use mockito instead of powermock [bookkeeper]

2024-02-20 Thread via GitHub
nodece closed pull request #4212: Use mockito instead of powermock URL: https://github.com/apache/bookkeeper/pull/4212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add `InetAddress.getLocalHost().getCanonicalHostName()` for UpdateMyRack. [bookkeeper]

2024-02-20 Thread via GitHub
horizonzy opened a new pull request, #4213: URL: https://github.com/apache/bookkeeper/pull/4213 The method `InetAddress.getLocalHost().getHostName()` result may be different from `InetAddress.getLocalHost().getCanonicalHostName()`. In the laptop, the method