Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-16 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1603202029 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java: ## @@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-16 Thread via GitHub
zymap commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1603023972 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java: ## @@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593328468 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593310578 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void initialize(AbstractConfiguration

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593307515 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593307515 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1592446786 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1592446786 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#issuecomment-2098209516 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-07 Thread via GitHub
congbobo184 commented on PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#issuecomment-2098192763 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1591777510 ## bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/DriverMetadataServiceAvailableTest.java: ## @@ -0,0 +1,53 @@ +/* + * + * Licensed to the Apache

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r159148 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java: ## @@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
zymap commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1591761669 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java: ## @@ -81,6 +81,13 @@ static BookKeeperBuilder newBuilder(final

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590949030 ## bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/DriverMetadataServiceAvailableTest.java: ## @@ -0,0 +1,54 @@ +/* + * + * Licensed to the Apache

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590948516 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -64,6 +66,8 @@ public class ZKMetadataDriverBase implements

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590948279 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java: ## @@ -247,6 +256,19 @@ protected void initialize(AbstractConfiguration

Re: [PR] [client] new API to check if Bookkeeper client is connected to metadata service [bookkeeper]

2024-05-06 Thread via GitHub
shoothzj commented on code in PR #4342: URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1590947324 ## bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/BookKeeper.java: ## @@ -81,6 +81,12 @@ static BookKeeperBuilder newBuilder(final