Re: [PR] add CompactionMaxTimeMillis in config.md [bookkeeper]

2024-05-09 Thread via GitHub
thetumbled commented on PR #4355: URL: https://github.com/apache/bookkeeper/pull/4355#issuecomment-2102360671 These conf are introduced in https://github.com/apache/bookkeeper/pull/2670, which was released in 4.14.0. So we have better add the description back into the config.md till

Re: [PR] add CompactionMaxTimeMillis in config.md [bookkeeper]

2024-05-09 Thread via GitHub
thetumbled commented on code in PR #4355: URL: https://github.com/apache/bookkeeper/pull/4355#discussion_r1595239598 ## site3/website/docs/reference/config.md: ## @@ -182,7 +182,8 @@ The table below lists parameters that you can set to configure bookies. All conf |

Re: [PR] add CompactionMaxTimeMillis in config.md [bookkeeper]

2024-05-09 Thread via GitHub
shoothzj commented on code in PR #4355: URL: https://github.com/apache/bookkeeper/pull/4355#discussion_r1595237071 ## site3/website/docs/reference/config.md: ## @@ -182,7 +182,8 @@ The table below lists parameters that you can set to configure bookies. All conf |

Re: [PR] add CompactionMaxTimeMillis in config.md [bookkeeper]

2024-05-09 Thread via GitHub
thetumbled commented on PR #4355: URL: https://github.com/apache/bookkeeper/pull/4355#issuecomment-2102335534 PTAL, thanks. @shoothzj @wenbingshen @eolivelli @dlg99 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the