shoothzj commented on issue #4043:
URL: https://github.com/apache/bookkeeper/issues/4043#issuecomment-2098547140
@lifepuzzlefun I use `file` command test 4.16.4, 4.16.5, 4.17.0, it's both
x86 arch, I think we can close this issue now. Feel free to reopen it if you
still have other
shoothzj opened a new pull request, #4349:
URL: https://github.com/apache/bookkeeper/pull/4349
Main Issue: may related to #1614
### Motivation
The `bkHttpServiceProvider` was not being closed after the completion of the
test cases in `TestHttpService`.
### Changes
shoothzj merged PR #4350:
URL: https://github.com/apache/bookkeeper/pull/4350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new c20213228e ci: add java21 Compatibility
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a change to branch shoothzj-patch-1
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
discard 3021c5383b doc: add the missing release news
add b4ffa20a1f build: remove unused cpp library rt
shoothzj commented on PR #4347:
URL: https://github.com/apache/bookkeeper/pull/4347#issuecomment-2097588428
@dlg99 IIUC, if you mean add jdk21 CI, I think we can open a new PR. And
shall we postpone it after jdk21 daily build sucesses?
We have added jdk 21 daily build in #4292
--
This
shoothzj opened a new pull request, #4348:
URL: https://github.com/apache/bookkeeper/pull/4348
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
shoothzj closed issue #1920: zkServers & metadataServerUri are both specified
in the config file by default
URL: https://github.com/apache/bookkeeper/issues/1920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
shoothzj commented on issue #1920:
URL: https://github.com/apache/bookkeeper/issues/1920#issuecomment-2099495790
I think it has been completed. We have marked zkServers deprecated, but keep
the zkServers for compatible, close this issue, feel free to reopen it if you
still have other
congbobo184 commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593307515
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void
congbobo184 commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593328468
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void
congbobo184 commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593307515
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void
shoothzj commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1593310578
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void initialize(AbstractConfiguration
shoothzj opened a new pull request, #4350:
URL: https://github.com/apache/bookkeeper/pull/4350
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
shoothzj commented on PR #4348:
URL: https://github.com/apache/bookkeeper/pull/4348#issuecomment-2099568553
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
shoothzj commented on PR #4350:
URL: https://github.com/apache/bookkeeper/pull/4350#issuecomment-2099568594
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
thetumbled commented on PR #4256:
URL: https://github.com/apache/bookkeeper/pull/4256#issuecomment-2097540068
> @shoothzj @thetumbled
>
> > @dlg99 Shall we put this configuration in `Replication Worker settings`
section?
>
> yeah, RW settings seem more relevant
I have
lhotari commented on issue #3511:
URL: https://github.com/apache/bookkeeper/issues/3511#issuecomment-2097513060
> @lhotari What can we do with dealing this issue? In `nar-maven-plugin`'s
documentation[1], `nar` is required. Adding some docs to
gradle user?
>
> [1]
horizonzy commented on code in PR #4324:
URL: https://github.com/apache/bookkeeper/pull/4324#discussion_r1591867045
##
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestRackawareEnsemblePlacementPolicy.java:
##
@@ -790,6 +791,55 @@ public void
shoothzj commented on code in PR #4324:
URL: https://github.com/apache/bookkeeper/pull/4324#discussion_r1591905333
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/client/RackawareEnsemblePlacementPolicyImpl.java:
##
@@ -792,9 +792,6 @@ protected List
shoothzj commented on PR #4343:
URL: https://github.com/apache/bookkeeper/pull/4343#issuecomment-2098146649
@zymap See
https://github.com/eclipse-vertx/vert.x/blob/1c1619e0f289d0f33aa9325f1819f4bd4447a56c/src/main/java/io/vertx/core/http/HttpServerOptions.java#L430-L435
--
This is an
congbobo184 commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1592446786
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void
congbobo184 commented on code in PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#discussion_r1592446786
##
bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/zk/ZKMetadataDriverBase.java:
##
@@ -247,6 +256,19 @@ protected void
shoothzj commented on PR #4340:
URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2098206949
@dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT
@wenbingshen @zhaijack PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message,
congbobo184 commented on PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#issuecomment-2098209516
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new c4fa8c2013 Fix improper negative key
shoothzj merged PR #4332:
URL: https://github.com/apache/bookkeeper/pull/4332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shoothzj closed issue #2077: ConcurrentLongHashSetTest.java: Math.abs does not
always give a positive result (errorprone warning)
URL: https://github.com/apache/bookkeeper/issues/2077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
congbobo184 commented on PR #4342:
URL: https://github.com/apache/bookkeeper/pull/4342#issuecomment-2098192763
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
29 matches
Mail list logo
