Re: [PR] test: fix bkHttpServiceProvider not closed in TestHttpService [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj commented on PR #4349: URL: https://github.com/apache/bookkeeper/pull/4349#issuecomment-2101857194 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix: resource leak when JournalChannel is not fully initialized [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj commented on PR #4340: URL: https://github.com/apache/bookkeeper/pull/4340#issuecomment-2101856802 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Added more relevant labels to .asf.yaml [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj commented on PR #4351: URL: https://github.com/apache/bookkeeper/pull/4351#issuecomment-2101859290 @dlg99 @eolivelli @hangc0276 @merlimat @nicoloboschi @StevenLuMT @wenbingshen @zhaijack PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] BP-66: support throttling for zookeeper read during rereplication [bookkeeper]

2024-05-08 Thread via GitHub
thetumbled commented on PR #4256: URL: https://github.com/apache/bookkeeper/pull/4256#issuecomment-2101820805 Please help to review, thanks. @wenbingshen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(bookkeeper) branch master updated: Disable two tests in BookKeeperTest on JDK 17+ due to UnsupportedOperationException (#4347)

2024-05-08 Thread shoothzj
This is an automated email from the ASF dual-hosted git repository. shoothzj pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/bookkeeper.git The following commit(s) were added to refs/heads/master by this push: new f66e962314 Disable two tests in

Re: [PR] Disable two tests in BookKeeperTest on JDK 17+ due to UnsupportedOperationException [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj merged PR #4347: URL: https://github.com/apache/bookkeeper/pull/4347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Added more relevant labels to .asf.yaml [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj opened a new pull request, #4351: URL: https://github.com/apache/bookkeeper/pull/4351 Fix #2229 Enhanced the .asf.yaml file by including additional, more appropriate labels. New labels added: - apache - distributed-log - distributed-systems - wal --

Re: [PR] Bump grpc from 1.56.0 to 1.63.0 to address CVE list [bookkeeper]

2024-05-08 Thread via GitHub
hangc0276 commented on PR #4344: URL: https://github.com/apache/bookkeeper/pull/4344#issuecomment-2100243758 We need to be careful to upgrade grpc versions. Pulsar also uses grpc and the version needs to be sync and compatible -- This is an automated message from the Apache Git Service.

Re: [PR] Bump grpc from 1.56.0 to 1.63.0 to address CVE list [bookkeeper]

2024-05-08 Thread via GitHub
shoothzj commented on PR #4344: URL: https://github.com/apache/bookkeeper/pull/4344#issuecomment-2100283162 > We need to be careful to upgrade grpc versions. Pulsar also uses grpc and the version needs to be sync and compatible I agree. But bk should go first. -- This is an