[GitHub] [calcite] danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278395006 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278393753 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392729 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392534 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlDialect.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392620 ## File path:

[GitHub] [calcite] danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392534 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlDialect.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r278392310 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r278392310 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392059 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278392059 ## File path:

[GitHub] [calcite] hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

2019-04-24 Thread GitBox
hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r278391735 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] danny0405 commented on issue #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 commented on issue #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#issuecomment-486514321 > Should be CALCITE-3016? Yes, thx for your prompt.

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278391597 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlDialect.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on a change in pull request #1181: [CALCITE-3016] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#discussion_r278391597 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlDialect.java

[GitHub] [calcite] danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

2019-04-24 Thread GitBox
danny0405 commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r278391478 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] chunweilei commented on issue #1181: [CALCITE-3017] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
chunweilei commented on issue #1181: [CALCITE-3017] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181#issuecomment-486513993 Should be CALCITE-3016? This is an automated

[GitHub] [calcite] danny0405 opened a new pull request #1181: [CALCITE-3017] Add sql dialect table operator factory to support all …

2019-04-24 Thread GitBox
danny0405 opened a new pull request #1181: [CALCITE-3017] Add sql dialect table operator factory to support all … URL: https://github.com/apache/calcite/pull/1181 …the sql dialect operators This is an automated message from

[GitHub] [calcite] shimamoto opened a new pull request #1180: [CALCITE-3023] Upgrade to Elasticsearch 7.0.0

2019-04-24 Thread GitBox
shimamoto opened a new pull request #1180: [CALCITE-3023] Upgrade to Elasticsearch 7.0.0 URL: https://github.com/apache/calcite/pull/1180 Types are deprecated in APIs in 7.0, with breaking changes to the index creation, put mapping, get mapping, put template, get template and get field

[GitHub] [calcite] julianhyde commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join

2019-04-24 Thread GitBox
julianhyde commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-486389610 Too busy to review right now. This is an automated message

[GitHub] [calcite] amaliujia commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs

2019-04-24 Thread GitBox
amaliujia commented on issue #1083: [CALCITE-2889] IndexOutOfBoundsException thrown if targetTypes[] contains varargs URL: https://github.com/apache/calcite/pull/1083#issuecomment-486379506 All green! @zabetak PTAL This is

[GitHub] [calcite] hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f…

2019-04-24 Thread GitBox
hsyuan commented on a change in pull request #1169: [CALCITE-2948] SqlToRelConverter generates complicated logical plan f… URL: https://github.com/apache/calcite/pull/1169#discussion_r278253570 ## File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml

[GitHub] [calcite] hsyuan closed pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

2019-04-24 Thread GitBox
hsyuan closed pull request #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783 This is an automated message from the Apache Git Service. To respond

[GitHub] [calcite] hsyuan commented on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon

2019-04-24 Thread GitBox
hsyuan commented on issue #783: [CALCITE-2453] Adding support of SQL statements separated by a semicolon URL: https://github.com/apache/calcite/pull/783#issuecomment-486336622 Fixed in https://github.com/apache/calcite/pull/1177, I am closing this PR. Thanks!

[GitHub] [calcite] chunweilei commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join

2019-04-24 Thread GitBox
chunweilei commented on issue #1160: [CALCITE-2712] Add rule to remove unnecessary outer join URL: https://github.com/apache/calcite/pull/1160#issuecomment-486273932 @julianhyde any other comments? This is an automated

[GitHub] [calcite] zhztheplayer commented on a change in pull request #1132: [CALCITE-2955] SQL queries after first query in same statement have no results returned

2019-04-24 Thread GitBox
zhztheplayer commented on a change in pull request #1132: [CALCITE-2955] SQL queries after first query in same statement have no results returned URL: https://github.com/apache/calcite/pull/1132#discussion_r278133449 ## File path: