[GitHub] [calcite] chunweilei commented on issue #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed

2019-05-16 Thread GitBox
chunweilei commented on issue #1215: [CALCITE-3068] testSubprogram() does not test whether subprogram gets re-executed URL: https://github.com/apache/calcite/pull/1215#issuecomment-493320852 @danny0405 could you please review this PR? Thanks a lot.

[GitHub] [calcite] LastSmile732 opened a new pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2

2019-05-16 Thread GitBox
LastSmile732 opened a new pull request #1218: [CALCITE-3067] Splunk Calcite adapter cannot parse right session keys from Splunk 7.2 URL: https://github.com/apache/calcite/pull/1218 Fix the regular expression for parsing session keys from Splunk 7.2+

[GitHub] [calcite] chunweilei commented on issue #1209: [CALCITE-2601] Support REVERSE(str) in SqlFunctions

2019-05-16 Thread GitBox
chunweilei commented on issue #1209: [CALCITE-2601] Support REVERSE(str) in SqlFunctions URL: https://github.com/apache/calcite/pull/1209#issuecomment-493315308 Please: * fix build fail * squash commits to one * change the commit message to '[CALCITE-2601] Add REVERSE function (

[calcite] branch master updated: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-16 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 4d04773 [CALCITE-2965] Implement string

[GitHub] [calcite] chunweilei merged pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
chunweilei merged pull request #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-493308964 Update to resolve conflicts. This is an

[GitHub] [calcite] zhztheplayer merged pull request #1217: [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators

2019-05-16 Thread GitBox
zhztheplayer merged pull request #1217: [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators URL: https://github.com/apache/calcite/pull/1217 This is an automated message from the Apache Git Service. To respond

[calcite] branch master updated: [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators

2019-05-16 Thread hongze
This is an automated email from the ASF dual-hosted git repository. hongze pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new ca92ce2 [CALCITE-3074] Move MySQL's JSON

[GitHub] [calcite] ambition119 commented on issue #1209: [CALCITE-2601] Support REVERSE(str) in SqlFunctions

2019-05-16 Thread GitBox
ambition119 commented on issue #1209: [CALCITE-2601] Support REVERSE(str) in SqlFunctions URL: https://github.com/apache/calcite/pull/1209#issuecomment-493302480 @julianhyde I don't see the details of the check error, I can only see the code that can't pull the PR, so I can't help

[GitHub] [calcite-avatica] ambition119 opened a new pull request #98: [Duplicate code] lastDay in calcite-avatica and calcite

2019-05-16 Thread GitBox
ambition119 opened a new pull request #98: [Duplicate code] lastDay in calcite-avatica and calcite URL: https://github.com/apache/calcite-avatica/pull/98 The code of lastDay appears in calcite(

[GitHub] [calcite] chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
chunweilei commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-493300057 Update to fix build fail. This is an

[GitHub] [calcite] DonnyZone commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect

2019-05-16 Thread GitBox
DonnyZone commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect URL: https://github.com/apache/calcite/pull/1216#issuecomment-493294543 @ambition119 thanks for reminder This is an

[GitHub] [calcite] hsyuan commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI…

2019-05-16 Thread GitBox
hsyuan commented on issue #1140: [CALCITE-2965] Implement string functions: REPEAT, SPACE, SOUNDEX, DI… URL: https://github.com/apache/calcite/pull/1140#issuecomment-493185259 LGTM. This is an automated message from the

[GitHub] [calcite] laurentgo merged pull request #1207: [CALCITE-3062] Do not populate provenanceMap if not debug

2019-05-16 Thread GitBox
laurentgo merged pull request #1207: [CALCITE-3062] Do not populate provenanceMap if not debug URL: https://github.com/apache/calcite/pull/1207 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] zhztheplayer opened a new pull request #1217: [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators

2019-05-16 Thread GitBox
zhztheplayer opened a new pull request #1217: [CALCITE-3074] Move MySQL's JSON operators to SqlLibraryOperators URL: https://github.com/apache/calcite/pull/1217 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] zhztheplayer closed pull request #1146: [CALCITE-2975] Implement JSON_REMOVE function

2019-05-16 Thread GitBox
zhztheplayer closed pull request #1146: [CALCITE-2975] Implement JSON_REMOVE function URL: https://github.com/apache/calcite/pull/1146 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] ambition119 commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect

2019-05-16 Thread GitBox
ambition119 commented on issue #1216: [CALCITE-3072] Generate right SQL for FLOOR functions in SparkSqlDialect URL: https://github.com/apache/calcite/pull/1216#issuecomment-493051293 @DonnyZone You can ```shell git config --global user.email "your github email" ``` then

[GitHub] [calcite] XuMingmin edited a comment on issue #1127: [CALCITE-2913] Adapter for Apache Kafka

2019-05-16 Thread GitBox
XuMingmin edited a comment on issue #1127: [CALCITE-2913] Adapter for Apache Kafka URL: https://github.com/apache/calcite/pull/1127#issuecomment-493033279 @wangzzu I would like this feature in a following task, to support both from/to timestamp/offset. Create

[GitHub] [calcite] XuMingmin commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka

2019-05-16 Thread GitBox
XuMingmin commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka URL: https://github.com/apache/calcite/pull/1127#issuecomment-493033279 @wangzzu I would like this feature in a following task, to support both from/to timestamp/offset.

[calcite] branch master updated: [CALCITE-2933] Add timestamp extract for casts from timestamp type to other types

2019-05-16 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 7df0678 [CALCITE-2933] Add timestamp

[GitHub] [calcite] danny0405 closed pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to…

2019-05-16 Thread GitBox
danny0405 closed pull request #1120: [CALCITE-2933] Add timestamp extract for casts from timestamp type to… URL: https://github.com/apache/calcite/pull/1120 This is an automated message from the Apache Git Service. To

[GitHub] [calcite] rubenada commented on issue #1183: [CALCITE-3021] ArrayEqualityComparer should use Arrays#deepEquals/deepHashCode instead of Arrays#equals/hashCode (Ruben Quesada Lopez)

2019-05-16 Thread GitBox
rubenada commented on issue #1183: [CALCITE-3021] ArrayEqualityComparer should use Arrays#deepEquals/deepHashCode instead of Arrays#equals/hashCode (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/1183#issuecomment-492972001 @julianhyde , you expressed some concerns in

[GitHub] [calcite] wangzzu commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka

2019-05-16 Thread GitBox
wangzzu commented on issue #1127: [CALCITE-2913] Adapter for Apache Kafka URL: https://github.com/apache/calcite/pull/1127#issuecomment-492931746 @XuMingmin Whether it is necessary to support user consume from the special timestamp?