yanlin-Lynn commented on a change in pull request #1557: [CALCITE-3473] Getting
unique result for table scan should contain key column(s)
URL: https://github.com/apache/calcite/pull/1557#discussion_r352446701
##
File path: core/src/main/java/org/apache/calcite/plan/RelOptAbstractTab
yanlin-Lynn commented on issue #1565: [CALCITE-3481] Support convert
TableFunctionScan to SqlNode
URL: https://github.com/apache/calcite/pull/1565#issuecomment-560265629
Test failed with
```
org.apache.calcite.adapter.elasticsearch.MatchTest > initializationError
FAILED
java.n
chunweilei commented on a change in pull request #1611: [CALCITE-3355] Deduce
whether CASE and COALESCE may produce NULL values
URL: https://github.com/apache/calcite/pull/1611#discussion_r352443939
##
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java
##
danny0405 commented on a change in pull request #1618: [hotfix] Fixed an issue
where overflow from Long to Int was unsafe
URL: https://github.com/apache/calcite/pull/1618#discussion_r352440547
##
File path: core/src/main/java/org/apache/calcite/rex/RexInterpreter.java
##
@
amaliujia commented on issue #1588: [CALCITE-3381] Unparse to correct BigQuery
interval syntax: "INTERVAL…
URL: https://github.com/apache/calcite/pull/1588#issuecomment-560257291
@danny0405 thanks for review last time! Could you take a look again?
-
amaliujia commented on a change in pull request #1618: [hotfix] Fixed an issue
where overflow from Long to Int was unsafe
URL: https://github.com/apache/calcite/pull/1618#discussion_r352439282
##
File path: core/src/main/java/org/apache/calcite/rex/RexInterpreter.java
##
@
yanlin-Lynn commented on issue #1565: [CALCITE-3481] Support convert
TableFunctionScan to SqlNode
URL: https://github.com/apache/calcite/pull/1565#issuecomment-560250554
> LGTM. Could you please resolve the conflicts and squash commits?
Thanks for reviewing @chunweilei
Sorry for
seancxmao commented on a change in pull request #1615: [CALCITE-3547]
SqlValidatorException because Planner cannot find UDFs added to schema
URL: https://github.com/apache/calcite/pull/1615#discussion_r352427839
##
File path: core/src/main/java/org/apache/calcite/prepare/PlannerImpl
DonnyZone commented on a change in pull request #1609: [CALCITE-3520] Type cast
from primitive to box is not correct
URL: https://github.com/apache/calcite/pull/1609#discussion_r352417543
##
File path:
core/src/test/java/org/apache/calcite/adapter/enumerable/EnumUtilsTest.java
###
danny0405 commented on issue #1138: [CALCITE-1581] UDTF like in hive
URL: https://github.com/apache/calcite/pull/1138#issuecomment-560221101
Thanks @pengzhiwei2018 for the update, maybe i can find some time to review
the latest change in this week ~
danny0405 commented on a change in pull request #1611: [CALCITE-3355] Deduce
whether CASE and COALESCE may produce NULL values
URL: https://github.com/apache/calcite/pull/1611#discussion_r352413652
##
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java
###
danny0405 commented on a change in pull request #1615: [CALCITE-3547]
SqlValidatorException because Planner cannot find UDFs added to schema
URL: https://github.com/apache/calcite/pull/1615#discussion_r352411833
##
File path: core/src/main/java/org/apache/calcite/prepare/PlannerImpl
seancxmao commented on a change in pull request #1615: [CALCITE-3547]
SqlValidatorException because Planner cannot find UDFs added to schema
URL: https://github.com/apache/calcite/pull/1615#discussion_r352408414
##
File path: core/src/test/java/org/apache/calcite/tools/PlannerTest.j
seancxmao commented on a change in pull request #1615: [CALCITE-3547]
SqlValidatorException because Planner cannot find UDFs added to schema
URL: https://github.com/apache/calcite/pull/1615#discussion_r352408289
##
File path: core/src/main/java/org/apache/calcite/prepare/PlannerImpl
chunweilei commented on a change in pull request #1611: [CALCITE-3355] Deduce
whether CASE and COALESCE may produce NULL values
URL: https://github.com/apache/calcite/pull/1611#discussion_r352398475
##
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java
##
danny0405 commented on a change in pull request #1618: [hotfix] Fixed an issue
where overflow from Long to Int was unsafe
URL: https://github.com/apache/calcite/pull/1618#discussion_r352391116
##
File path: core/src/main/java/org/apache/calcite/rex/RexInterpreter.java
##
@
danny0405 commented on a change in pull request #1618: [hotfix] Fixed an issue
where overflow from Long to Int was unsafe
URL: https://github.com/apache/calcite/pull/1618#discussion_r352391116
##
File path: core/src/main/java/org/apache/calcite/rex/RexInterpreter.java
##
@
danny0405 commented on a change in pull request #1611: [CALCITE-3355] Deduce
whether CASE and COALESCE may produce NULL values
URL: https://github.com/apache/calcite/pull/1611#discussion_r352390724
##
File path: core/src/main/java/org/apache/calcite/sql/fun/SqlCaseOperator.java
###
This is an automated email from the ASF dual-hosted git repository.
francischuang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git
The following commit(s) were added to refs/heads/master by this push:
new 3141a14 [CALCITE-3493] Update d
19 matches
Mail list logo