[GitHub] [calcite] jamesstarr commented on a change in pull request #2585: [CALCITE-4551] Reusing Immutable metadata cache keys

2021-10-27 Thread GitBox
jamesstarr commented on a change in pull request #2585: URL: https://github.com/apache/calcite/pull/2585#discussion_r737982613 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/janino/DescriptiveCacheKey.java ## @@ -16,14 +16,18 @@ */ package

[GitHub] [calcite] chunweilei merged pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
chunweilei merged pull request #2559: URL: https://github.com/apache/calcite/pull/2559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGTH for BigQuery dialect

2021-10-27 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new f61541d [CALCITE-4822] Add functions

[GitHub] [calcite] chunweilei closed pull request #2589: Fix typo in reference.md

2021-10-27 Thread GitBox
chunweilei closed pull request #2589: URL: https://github.com/apache/calcite/pull/2589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[calcite] branch master updated: Fix typo in reference.md

2021-10-27 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 5bec337 Fix typo in reference.md 5bec337 is

[calcite] branch master updated: [CALCITE-4818] AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls (Taras Ledkov)

2021-10-27 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 3af1d78 [CALCITE-4818]

[GitHub] [calcite] chunweilei closed pull request #2560: [CALCITE-4818] AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls

2021-10-27 Thread GitBox
chunweilei closed pull request #2560: URL: https://github.com/apache/calcite/pull/2560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2546: [CALCITE-4803] AggregateProjectMergeRule lost alias after remove the …

2021-10-27 Thread GitBox
xy2953396112 commented on a change in pull request #2546: URL: https://github.com/apache/calcite/pull/2546#discussion_r737969304 ## File path: core/src/main/java/org/apache/calcite/rel/rules/AggregateProjectMergeRule.java ## @@ -125,14 +125,17 @@ public

[GitHub] [calcite] NobiGo commented on a change in pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
NobiGo commented on a change in pull request #2559: URL: https://github.com/apache/calcite/pull/2559#discussion_r737959127 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@ -2657,6 +2664,38 @@ private static RelDataType

[GitHub] [calcite] NobiGo commented on a change in pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
NobiGo commented on a change in pull request #2559: URL: https://github.com/apache/calcite/pull/2559#discussion_r737958944 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@ -2657,6 +2664,38 @@ private static RelDataType

[GitHub] [calcite] NobiGo commented on a change in pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
NobiGo commented on a change in pull request #2559: URL: https://github.com/apache/calcite/pull/2559#discussion_r737958837 ## File path: site/_docs/reference.md ## @@ -2513,6 +2513,9 @@ semantics. | C | Operator syntax| Description |:-

[GitHub] [calcite-avatica] joshelser commented on pull request #132: [CALCITE-4152] Switch to ConfigurableSpnego Jetty implementations

2021-10-27 Thread GitBox
joshelser commented on pull request #132: URL: https://github.com/apache/calcite-avatica/pull/132#issuecomment-953398364 Also, fyi @stoty -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] jcamachor commented on a change in pull request #2585: [CALCITE-4551] Reusing Immutable metadata cache keys

2021-10-27 Thread GitBox
jcamachor commented on a change in pull request #2585: URL: https://github.com/apache/calcite/pull/2585#discussion_r737893951 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/janino/CacheGenerator.java ## @@ -0,0 +1,419 @@ +/* + * Licensed to the Apache

[GitHub] [calcite] jbalint commented on pull request #2560: [CALCITE-4818] AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls

2021-10-27 Thread GitBox
jbalint commented on pull request #2560: URL: https://github.com/apache/calcite/pull/2560#issuecomment-953114778 @tledkov-gridgain can you squash (and rebase) and then we'll merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] asolimando commented on pull request #2592: [CALCITE-4768] cassandra4

2021-10-27 Thread GitBox
asolimando commented on pull request #2592: URL: https://github.com/apache/calcite/pull/2592#issuecomment-953100170 Never mind, I have added the description because there was a conflict to fix with master (gradle.properties). -- This is an automated message from the Apache Git Service.

[calcite] branch master updated: [CALCITE-4858] Use Log4j2 instead of unsupported Log4j (1.x) in tests

2021-10-27 Thread zabetak
This is an automated email from the ASF dual-hosted git repository. zabetak pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 2280879 [CALCITE-4858] Use Log4j2 instead of

[GitHub] [calcite] zabetak closed pull request #2587: [CALCITE-4858] Use Log4j2 instead of unsupported Log4j (1.x) in tests

2021-10-27 Thread GitBox
zabetak closed pull request #2587: URL: https://github.com/apache/calcite/pull/2587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando edited a comment on pull request #2592: [CALCITE-4768] cassandra4

2021-10-27 Thread GitBox
asolimando edited a comment on pull request #2592: URL: https://github.com/apache/calcite/pull/2592#issuecomment-952730479 On a second thought, there are some important info in the PR description that I think should be in the git description as well, could you add it when merging the PR?

[GitHub] [calcite] asolimando commented on pull request #2592: [CALCITE-4768] cassandra4

2021-10-27 Thread GitBox
asolimando commented on pull request #2592: URL: https://github.com/apache/calcite/pull/2592#issuecomment-952730479 On a second thought, there are some important info in the PR description that I think should be in the git description as well, could you add it when merging the PR?

[GitHub] [calcite] snuyanzin commented on a change in pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
snuyanzin commented on a change in pull request #2559: URL: https://github.com/apache/calcite/pull/2559#discussion_r737287102 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java ## @@ -2657,6 +2664,38 @@ private static RelDataType

[GitHub] [calcite] snuyanzin commented on a change in pull request #2559: [CALCITE-4822] Add functions ARRAY_CONCAT, ARRAY_REVERSE, ARRAY_LENGT…

2021-10-27 Thread GitBox
snuyanzin commented on a change in pull request #2559: URL: https://github.com/apache/calcite/pull/2559#discussion_r737273675 ## File path: site/_docs/reference.md ## @@ -2513,6 +2513,9 @@ semantics. | C | Operator syntax| Description |:-

[GitHub] [calcite] asolimando edited a comment on pull request #2592: [CALCITE-4768] cassandra4

2021-10-27 Thread GitBox
asolimando edited a comment on pull request #2592: URL: https://github.com/apache/calcite/pull/2592#issuecomment-952638170 Thank you both for the review, I have squashed the commits and updated the commit message, once the test are over (even though there are no code changes since last

[GitHub] [calcite] asolimando commented on pull request #2592: [CALCITE-4768] cassandra4

2021-10-27 Thread GitBox
asolimando commented on pull request #2592: URL: https://github.com/apache/calcite/pull/2592#issuecomment-952638170 Thank you both for the review, I have squashed the commits and updated the commit message, once the test are over I think it can be merged. -- This is an automated message