[GitHub] [calcite] sonarcloud[bot] commented on pull request #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3196: URL: https://github.com/apache/calcite/pull/3196#issuecomment-1543273226 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] herunkang2018 opened a new pull request, #3196: [CALCITE-5691] IN sub-query inside FILTER clause throws IndexOutOfBoundsException

2023-05-10 Thread via GitHub
herunkang2018 opened a new pull request, #3196: URL: https://github.com/apache/calcite/pull/3196 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1543204521 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1190558850 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5361,6 +5361,28 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1190558694 ## site/_docs/reference.md: ## @@ -2723,6 +2723,8 @@ BigQuery's type system uses confusingly different names for types and functions: | m | TO_BASE64(string)

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3189: URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542959192 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite-avatica] julianhyde closed pull request #218: CALCITE-5678 Validate incorrect datetime string representation

2023-05-10 Thread via GitHub
julianhyde closed pull request #218: CALCITE-5678 Validate incorrect datetime string representation URL: https://github.com/apache/calcite-avatica/pull/218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[calcite-avatica] branch main updated: [CALCITE-5678] Validate date, time and timestamp literals per ISO-8601

2023-05-10 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git The following commit(s) were added to refs/heads/main by this push: new 05e07c151 [CALCITE-5678] Validate date,

[GitHub] [calcite] julianhyde commented on a diff in pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-10 Thread via GitHub
julianhyde commented on code in PR #3179: URL: https://github.com/apache/calcite/pull/3179#discussion_r1190362519 ## core/src/test/java/org/apache/calcite/test/JdbcFrontLinqBackTest.java: ## @@ -343,12 +356,13 @@ private CalciteAssert.AssertThat mutable(

[GitHub] [calcite] julianhyde commented on a diff in pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-10 Thread via GitHub
julianhyde commented on code in PR #3179: URL: https://github.com/apache/calcite/pull/3179#discussion_r1190359548 ## core/src/test/java/org/apache/calcite/test/JdbcFrontLinqBackTest.java: ## @@ -343,12 +356,13 @@ private CalciteAssert.AssertThat mutable(

[GitHub] [calcite] julianhyde commented on a diff in pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-10 Thread via GitHub
julianhyde commented on code in PR #3179: URL: https://github.com/apache/calcite/pull/3179#discussion_r1190355718 ## core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java: ## @@ -837,8 +837,16 @@ private static ColumnMetaData.AvaticaType

[GitHub] [calcite] julianhyde commented on a diff in pull request #3179: [CALCITE-5676] Set `DATA_TYPE` and `TYPE_NAME` metadata values for `MEASURE` types

2023-05-10 Thread via GitHub
julianhyde commented on code in PR #3179: URL: https://github.com/apache/calcite/pull/3179#discussion_r1190355718 ## core/src/main/java/org/apache/calcite/prepare/CalcitePrepareImpl.java: ## @@ -837,8 +837,16 @@ private static ColumnMetaData.AvaticaType

[GitHub] [calcite] julianhyde commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
julianhyde commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1190352269 ## site/_docs/reference.md: ## @@ -2723,6 +2723,8 @@ BigQuery's type system uses confusingly different names for types and functions: | m | TO_BASE64(string)

[GitHub] [calcite] allai5 closed pull request #3195: Alice/support join using compound identifiers

2023-05-10 Thread via GitHub
allai5 closed pull request #3195: Alice/support join using compound identifiers URL: https://github.com/apache/calcite/pull/3195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] allai5 opened a new pull request, #3195: Alice/support join using compound identifiers

2023-05-10 Thread via GitHub
allai5 opened a new pull request, #3195: URL: https://github.com/apache/calcite/pull/3195 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] HanumathRao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-10 Thread via GitHub
HanumathRao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1190174369 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] tanclary commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
tanclary commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1190144100 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -5361,6 +5361,28 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3189: URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542307080 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite-avatica] stoty commented on pull request #217: CALCITE-5581: Client side LB implementation

2023-05-10 Thread via GitHub
stoty commented on PR #217: URL: https://github.com/apache/calcite-avatica/pull/217#issuecomment-1542101644 One more thing, @vaijosh . Please change the commit message to match the Avatica convention. i.e. use square brackets instead of colon. -- This is an automated message from

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3189: [CALCITE-5674] Cast expr to target type should respect nullable when …

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3189: URL: https://github.com/apache/calcite/pull/3189#issuecomment-1542059036 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189758110 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] libenchao commented on a diff in pull request #3193: [CALCITE-5683] Two level nested correlated subquery throws an excepti…

2023-05-10 Thread via GitHub
libenchao commented on code in PR #3193: URL: https://github.com/apache/calcite/pull/3193#discussion_r1189755471 ## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ## @@ -6823,6 +6824,65 @@ private void checkSemiJoinRuleOnAntiJoin(RelOptRule rule) {

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189754135 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] libenchao commented on a diff in pull request #3191: [CALCITE-5693] AssertionError with UNION using CTE

2023-05-10 Thread via GitHub
libenchao commented on code in PR #3191: URL: https://github.com/apache/calcite/pull/3191#discussion_r1189744018 ## core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java: ## @@ -135,6 +135,14 @@ class JdbcAdapterTest { + "WHERE \"product_id\" = 1"); }

[GitHub] [calcite] libenchao commented on a diff in pull request #3191: [CALCITE-5693] AssertionError with UNION using CTE

2023-05-10 Thread via GitHub
libenchao commented on code in PR #3191: URL: https://github.com/apache/calcite/pull/3191#discussion_r1189742157 ## core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -4021,19 +4021,30 @@ private void validateModality(SqlNode query) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541883937 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541798449 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] zoudan commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
zoudan commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189631187 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] liuyongvs commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189605267 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] zoudan commented on a diff in pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
zoudan commented on code in PR #3194: URL: https://github.com/apache/calcite/pull/3194#discussion_r1189565277 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -3797,6 +3798,16 @@ public static List distinct(List list) { return new

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
sonarcloud[bot] commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541473544 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] liuyongvs commented on pull request #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs commented on PR #3194: URL: https://github.com/apache/calcite/pull/3194#issuecomment-1541451693 hi @JiajunBernoulli could you also help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] liuyongvs opened a new pull request, #3194: [CALCITE-5695] Add MAP_KEYS, MAP_VALUES function (enabled in Spark li…

2023-05-10 Thread via GitHub
liuyongvs opened a new pull request, #3194: URL: https://github.com/apache/calcite/pull/3194 MAP_KEYS - Returns an unordered array containing the keys of the map. If the map itself is null, the function will return null. MAP_VALUES - Returns an unordered array containing the values