[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1311102272 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703857407 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703857503 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

sonarcloud[bot] commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703854702 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [calcite] LakeShen commented on pull request #3396: [CALCITE-5940] Add the Rules to optimize Limit

LakeShen commented on PR #3396: URL: https://github.com/apache/calcite/pull/3396#issuecomment-1703849466 @kgyrtkirk ,Thank you for your review suggestions. I have modified according to the suggestions. If you have time, please help me review it again -- This is an automated message from

[GitHub] [calcite] LakeShen commented on pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

LakeShen commented on PR #3367: URL: https://github.com/apache/calcite/pull/3367#issuecomment-1703830009 @tanclary @asolimando @NobiGo ,Thank you for your review suggestions. I have modified according to the suggestions. If you have time, please help me review it again:) -- This is an

[GitHub] [calcite] LakeShen commented on a diff in pull request #3367: [CALCITE-5889] Add the RelRule that converts Minus into UNION ALL..GROUP BY...WHERE

LakeShen commented on code in PR #3367: URL: https://github.com/apache/calcite/pull/3367#discussion_r1313824184 ## core/src/test/java/org/apache/calcite/test/JdbcTest.java: ## @@ -3773,6 +3774,35 @@ public void checkOrderBy(final boolean desc, "empid=110;

[GitHub] [calcite] jiefei30 commented on pull request #3406: fix bug when es index mapping set dynamic_templates without properties

jiefei30 commented on PR #3406: URL: https://github.com/apache/calcite/pull/3406#issuecomment-1703773684 > when use es-adapter, A index set dynamic_templates bug no mappings causing exceptions: > > java.lang.ClassCastException: com.fasterxml.jackson.databind.node.ArrayNode cannot be

[GitHub] [calcite] macroguo-ghy commented on a diff in pull request #3389: [CALCITE-5935] Add CODE_POINTS_TO_BYTES function (enabled in BigQuery…

macroguo-ghy commented on code in PR #3389: URL: https://github.com/apache/calcite/pull/3389#discussion_r1313783485 ## site/_docs/reference.md: ## @@ -2685,6 +2685,7 @@ BigQuery's type system uses confusingly different names for types and functions: | b | CEIL(value)

[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3397: [CALCITE-5836] Implement Rel2Sql for MERGE

JiajunBernoulli commented on code in PR #3397: URL: https://github.com/apache/calcite/pull/3397#discussion_r1313773990 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -7027,6 +7027,136 @@ private void checkLiteral2(String expression,