[GitHub] [calcite-avatica] zstan commented on a diff in pull request #225: [CALCITE-5957] Date representation string without precede 0 is acceptable

2023-09-03 Thread via GitHub
zstan commented on code in PR #225: URL: https://github.com/apache/calcite-avatica/pull/225#discussion_r1314458931 ## core/src/test/java/org/apache/calcite/avatica/util/TimestampFromNumberAccessorTest.java: ## @@ -101,6 +101,9 @@ public class TimestampFromNumberAccessorTest {

[GitHub] [calcite] zoov-w commented on pull request #3406: [CALCITE-5974] fix bug when es index mapping set dynamic_templates without properties

2023-09-03 Thread via GitHub
zoov-w commented on PR #3406: URL: https://github.com/apache/calcite/pull/3406#issuecomment-1704247919 @jiefei30 Thanks, I pushed PR again according to [contribution rules](https://calcite.apache.org/develop/#contributing). -- This is an automated message from the Apache Git Service.

[GitHub] [calcite] sonarcloud[bot] commented on pull request #3406: [CALCITE-5974] fix bug when es index mapping set dynamic_templates without properties

2023-09-03 Thread via GitHub
sonarcloud[bot] commented on PR #3406: URL: https://github.com/apache/calcite/pull/3406#issuecomment-1704236810 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png