YiwenWu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1487094978
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -1074,6 +1080,26 @@ static RelDataType deriveTypeSplit(SqlOperatorBinding
sonarcloud[bot] commented on PR #3683:
URL: https://github.com/apache/calcite/pull/3683#issuecomment-1940337911
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
YiwenWu commented on code in PR #3683:
URL: https://github.com/apache/calcite/pull/3683#discussion_r1487082616
##
core/src/main/java/org/apache/calcite/sql/dialect/PrestoSqlDialect.java:
##
@@ -131,8 +136,30 @@ private static void unparseUsingLimit(SqlWriter writer,
@Nullable
YiwenWu commented on code in PR #3683:
URL: https://github.com/apache/calcite/pull/3683#discussion_r1487081624
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -4169,7 +4171,10 @@ private SqlDialect nonOrdinalDialect() {
final String
jnh5y commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r1486959295
##
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##
@@ -312,7 +312,9 @@ private Expression getConvertExpression(
case CHAR:
julianhyde commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r1486928091
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -1140,27 +1140,447 @@ public enum SqlKind {
// Spatial functions. They are registered as
julianhyde commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r1486918013
##
core/src/main/java/org/apache/calcite/sql/dialect/PostgisSqlDialect.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
sonarcloud[bot] commented on PR #3685:
URL: https://github.com/apache/calcite/pull/3685#issuecomment-1939759965
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
mihaibudiu opened a new pull request, #3685:
URL: https://github.com/apache/calcite/pull/3685
This PR is a pair to https://github.com/apache/calcite-avatica/pull/238 and
should be merged before the other one can pass.
It only changes a few date literals in tests to conform to the
sonarcloud[bot] commented on PR #3680:
URL: https://github.com/apache/calcite/pull/3680#issuecomment-1939734784
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3677:
URL: https://github.com/apache/calcite/pull/3677#issuecomment-1939709400
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
mihaibudiu commented on code in PR #3680:
URL: https://github.com/apache/calcite/pull/3680#discussion_r1486861642
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -57,8 +59,17 @@ public enum FormatElementEnum implements FormatElement {
},
mihaibudiu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1486819673
##
babel/src/test/java/org/apache/calcite/test/BabelQuidemTest.java:
##
@@ -131,6 +131,16 @@ public static void main(String[] args) throws Exception {
julianhyde commented on PR #3635:
URL: https://github.com/apache/calcite/pull/3635#issuecomment-1939623618
Can we have design discussions in jira?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch site
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/site by this push:
new 6c3386c347 [CALCITE-6250] Limitations of
This is an automated email from the ASF dual-hosted git repository.
asf-ci-deploy pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite-site.git
The following commit(s) were added to refs/heads/main by this push:
new df42fbfd6 Website deployed from
This is an automated email from the ASF dual-hosted git repository.
mbudiu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new e05b0473a0 [CALCITE-6250] Limitations of MongoDB
mihaibudiu merged PR #3676:
URL: https://github.com/apache/calcite/pull/3676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mihaibudiu commented on PR #3635:
URL: https://github.com/apache/calcite/pull/3635#issuecomment-1939616304
These are very good questions. Indeed, this PR the "Enumerable"
implementation. But that implementation is special, because it is the one used
when Calcite optimizations simplify a
mihaibudiu commented on code in PR #3682:
URL: https://github.com/apache/calcite/pull/3682#discussion_r1486629721
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -4506,13 +4600,16 @@ private void checkLiteral2(String expression, String
sonarcloud[bot] commented on PR #3684:
URL: https://github.com/apache/calcite/pull/3684#issuecomment-1939122808
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3683:
URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939092167
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3683:
URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939075027
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3683:
URL: https://github.com/apache/calcite/pull/3683#issuecomment-1939027076
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
gortiz commented on PR #3635:
URL: https://github.com/apache/calcite/pull/3635#issuecomment-1938501532
I have a couple of questions about this PR.
## does it actually fix the issue?
The issue was the assertion error when casting STRING to VARBINARY. I'm not
an expert on Apache
caicancai commented on code in PR #3631:
URL: https://github.com/apache/calcite/pull/3631#discussion_r1486012354
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -8747,6 +8747,55 @@ private void testCurrentDateFunc(Pair pair) {
}
}
+ /**
sonarcloud[bot] commented on PR #3676:
URL: https://github.com/apache/calcite/pull/3676#issuecomment-1938274801
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
TheOezzi commented on PR #3676:
URL: https://github.com/apache/calcite/pull/3676#issuecomment-1938240388
I've adapted the commit and title according to your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
rubenql pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new abf462a7dd [CALCITE-6251] InnerEnumerator in
rubenada merged PR #3675:
URL: https://github.com/apache/calcite/pull/3675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
30 matches
Mail list logo