macroguo-ghy commented on PR #3776:
URL: https://github.com/apache/calcite/pull/3776#issuecomment-2081298326
Thanks @snuyanzin .
A minor comment: better remove `--add-opens` in
https://github.com/apache/calcite/blob/d4e88302e367b7f5a3b3da9d2e0f734320cef413/Jenkinsfile#L44-L46
--
mihaibudiu commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2081261317
I have approved, but also left some questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
mihaibudiu commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1581975923
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1581903678
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1581902891
##
core/src/main/java/org/apache/calcite/plan/RelCompositeTrait.java:
##
@@ -116,4 +116,5 @@ public T trait(int i) {
public int size() {
return
asolimando commented on code in PR #3760:
URL: https://github.com/apache/calcite/pull/3760#discussion_r1581902574
##
core/src/main/java/org/apache/calcite/rel/rules/JoinDeriveEquivalenceFilterRule.java:
##
@@ -0,0 +1,380 @@
+/*
+ * Licensed to the Apache Software Foundation
sonarcloud[bot] commented on PR #3777:
URL: https://github.com/apache/calcite/pull/3777#issuecomment-2081173410
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
guluo2016 opened a new pull request, #3775:
URL: https://github.com/apache/calcite/pull/3775
Details see:
[CALCITE-6386](https://issues.apache.org/jira/browse/CALCITE-6386)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
17 matches
Mail list logo
