DashShen commented on PR #3780:
URL: https://github.com/apache/calcite/pull/3780#issuecomment-2084326377
This bug fix addresses the issue that arises when there are seven parameters.
However, it is theoretically possible to encounter the same problem if the
number of elements exceeds
mihaibudiu commented on PR #3780:
URL: https://github.com/apache/calcite/pull/3780#issuecomment-2084322978
Does this fix the bug in general, or just for 6 arguments?
If the bug persists for 7 arguments, what should be done about it?
Your commit should have the same text as the issue
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2083809944
@mihaibudiu
> Until https://issues.apache.org/jira/browse/CALCITE-6281 has a solution,
the best way to test this may be to create a Quidem test file (.iq suffix). If
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a change to annotated tag calcite-1.37.0-rc5
in repository https://gitbox.apache.org/repos/asf/calcite.git
*** WARNING: tag calcite-1.37.0-rc5 was deleted! ***
tag was 25b562b233
The revisions that were
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854856
##
core/src/test/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatterTest.java:
##
@@ -0,0 +1,1238 @@
+/*
+ * Licensed to the Apache Software
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854741
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854483
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2083797456
@caicancai
> I remember that calcite currently has support for the postgres to_char
function. Should we remove the previous support?
The existing TO_CHAR function
sonarcloud[bot] commented on PR #3779:
URL: https://github.com/apache/calcite/pull/3779#issuecomment-208314
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2083758777
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
mihaibudiu opened a new pull request, #3779:
URL: https://github.com/apache/calcite/pull/3779
… types of literal
There are at least two other issues that I attempted to fix which uncover
this bug, so I decided to make a separate PR for fixing it. This should make
the other PRs
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a change to annotated tag calcite-1.37.0-rc5
in repository https://gitbox.apache.org/repos/asf/calcite.git
*** WARNING: tag calcite-1.37.0-rc5 was modified! ***
from 044db3d72e (commit)
to 25b562b233
Author: snuyanzin
Date: Mon Apr 29 19:16:50 2024
New Revision: 68871
Log:
Uploading release candidate Apache Calcite calcite-1.37.0-rc5 to dev area
Added:
dev/calcite/apache-calcite-1.37.0-rc5/
dev/calcite/apache-calcite-1.37.0-rc5/apache-calcite-1.37.0-src.tar.gz
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583563688
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583542999
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1583519841
##
core/src/main/java/org/apache/calcite/plan/RelCompositeTrait.java:
##
@@ -116,4 +116,5 @@ public T trait(int i) {
public int size() {
return traits.length;
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583472991
##
core/src/test/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatterTest.java:
##
@@ -0,0 +1,1238 @@
+/*
+ * Licensed to the Apache Software
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583396449
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583396047
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583385179
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583378225
##
core/src/test/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatterTest.java:
##
@@ -0,0 +1,1238 @@
+/*
+ * Licensed to the Apache Software
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583376456
##
babel/src/test/resources/sql/postgresql.iq:
##
@@ -58,11 +58,341 @@ NAME, PAY_BY_QUARTER, SCHEDULE
Bill, [1, 1, 1, 1], [[meeting, lunch],
sonarcloud[bot] commented on PR #3768:
URL: https://github.com/apache/calcite/pull/3768#issuecomment-2082915434
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a change to annotated tag calcite-1.37.0-rc4
in repository https://gitbox.apache.org/repos/asf/calcite.git
*** WARNING: tag calcite-1.37.0-rc4 was modified! ***
from 044db3d72e (commit)
to c5447f7d50
Author: snuyanzin
Date: Mon Apr 29 14:03:36 2024
New Revision: 68858
Log:
Need for Apache Calcite rc4
Removed:
dev/calcite/apache-calcite-1.37.0-rc3/
Author: snuyanzin
Date: Mon Apr 29 14:01:44 2024
New Revision: 68857
Log:
Uploading release candidate Apache Calcite calcite-1.37.0-rc4 to dev area
Added:
dev/calcite/apache-calcite-1.37.0-rc4/
dev/calcite/apache-calcite-1.37.0-rc4/apache-calcite-1.37.0-src.tar.gz
This is an automated email from the ASF dual-hosted git repository.
snuyanzin pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 1506857f40 [CALCITE-6390] Exclude Arrow project
snuyanzin closed pull request #3778: [CALCITE-6390] Exclude Arrow project on
Windows builds
URL: https://github.com/apache/calcite/pull/3778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sonarcloud[bot] commented on PR #3778:
URL: https://github.com/apache/calcite/pull/3778#issuecomment-2082576464
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
zabetak commented on code in PR #3778:
URL: https://github.com/apache/calcite/pull/3778#discussion_r1582952942
##
arrow/build.gradle.kts:
##
@@ -36,6 +37,7 @@ dependencies {
plugins.withType {
tasks {
configureEach {
+enabled =
snuyanzin commented on PR #3778:
URL: https://github.com/apache/calcite/pull/3778#issuecomment-2082430545
Thanks for working on this
agree with @rubenada 's comments
the rest is ok to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rubenada commented on code in PR #3778:
URL: https://github.com/apache/calcite/pull/3778#discussion_r1582836823
##
arrow/build.gradle.kts:
##
@@ -36,6 +37,7 @@ dependencies {
plugins.withType {
tasks {
configureEach {
+enabled =
rubenada commented on code in PR #3778:
URL: https://github.com/apache/calcite/pull/3778#discussion_r1582836823
##
arrow/build.gradle.kts:
##
@@ -36,6 +37,7 @@ dependencies {
plugins.withType {
tasks {
configureEach {
+enabled =
sonarcloud[bot] commented on PR #3778:
URL: https://github.com/apache/calcite/pull/3778#issuecomment-2082372482
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3778:
URL: https://github.com/apache/calcite/pull/3778#issuecomment-2082326911
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
sonarcloud[bot] commented on PR #3778:
URL: https://github.com/apache/calcite/pull/3778#issuecomment-2082321860
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
'Quality Gate
36 matches
Mail list logo