Re: [PR] [CALCITE-6376] Selecting 6 columns with QUALIFY operation results in exception [calcite]

2024-04-30 Thread via GitHub
sonarcloud[bot] commented on PR #3781: URL: https://github.com/apache/calcite/pull/3781#issuecomment-2087267511 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6376] Selecting 6 columns with QUALIFY operation results in exception [calcite]

2024-04-30 Thread via GitHub
sonarcloud[bot] commented on PR #3781: URL: https://github.com/apache/calcite/pull/3781#issuecomment-2086722716 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6376]Filtering CTE of at least 6 columns with QUALIFY operation results in exception. [calcite]

2024-04-30 Thread via GitHub
mihaibudiu commented on PR #3780: URL: https://github.com/apache/calcite/pull/3780#issuecomment-2086535842 If hope that #3781 solves the underlying problem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-04-30 Thread via GitHub
mihaibudiu commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2086209425 This is pretty close, the existing file `core/src/test/resources/sql/sub-query.iq` already uses the postgres format. What I would do is to make a small python script to convert the

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-04-30 Thread via GitHub
normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2085910494 @mihaibudiu Here is the output of a PostgreSQL script running all of the `TO_CHAR` tests from the `postgresql.iq` file in this PR. I kept the expected output for Calcite in SQL

Re: [PR] [CALCITE-6376]Filtering CTE of at least 6 columns with QUALIFY operation results in exception. [calcite]

2024-04-30 Thread via GitHub
mihaibudiu commented on PR #3780: URL: https://github.com/apache/calcite/pull/3780#issuecomment-2085841915 The "right' fix is to make ComparableListImpl support the required operations, isn't it? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6376]Filtering CTE of at least 6 columns with QUALIFY operation results in exception. [calcite]

2024-04-30 Thread via GitHub
DashShen commented on PR #3780: URL: https://github.com/apache/calcite/pull/3780#issuecomment-2084493120 > Can there anything be done to handle the case for 8 or more without creating a class for every case? No more, I didn't find a better way to fix these cases for 8 or more

Re: [PR] [CALCITE-6376]Filtering CTE of at least 6 columns with QUALIFY operation results in exception. [calcite]

2024-04-30 Thread via GitHub
mihaibudiu commented on PR #3780: URL: https://github.com/apache/calcite/pull/3780#issuecomment-2084470716 Can there anything be done to handle the case for 8 or more without creating a class for every case? -- This is an automated message from the Apache Git Service. To respond to