caicancai commented on PR #3787:
URL: https://github.com/apache/calcite/pull/3787#issuecomment-2105578522
@mihaibudiu @chucheng92 Good to merge？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sonarcloud[bot] commented on PR #3787:
URL: https://github.com/apache/calcite/pull/3787#issuecomment-2105505318
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597164314
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10397,6 +10397,50 @@ void assertSubFunReturns(boolean binary, String s, int
start,
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597163878
##
site/_docs/reference.md:
##
@@ -2812,6 +2812,7 @@ In the following:
| b m p s | MD5(string) | Calculates an MD5
128-bit checksum
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597162522
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597162056
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx,
SqlCall
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597161501
##
core/src/main/java/org/apache/calcite/sql2rel/StandardConvertletTable.java:
##
@@ -418,6 +419,32 @@ private static RexNode convertNvl(SqlRexContext cx,
SqlCall
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597157484
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) {
opBinding ->
julianhyde commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1597156525
##
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##
@@ -421,9 +421,12 @@ public enum SqlKind {
/** {@code DECODE} function (Oracle). */
DECODE,
-
sonarcloud[bot] commented on PR #3733:
URL: https://github.com/apache/calcite/pull/3733#issuecomment-2105155879
## [ were added to refs/heads/main by this push:
new c228804e25 [CALCITE-6389]
mihaibudiu merged PR #3779:
URL: https://github.com/apache/calcite/pull/3779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
snuyanzin commented on code in PR #3779:
URL: https://github.com/apache/calcite/pull/3779#discussion_r1597039588
##
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##
@@ -1822,6 +1823,35 @@ public static RelDataType
extractLastNFields(RelDataTypeFactory
mihaibudiu commented on code in PR #3779:
URL: https://github.com/apache/calcite/pull/3779#discussion_r1597033016
##
core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java:
##
@@ -1822,6 +1823,35 @@ public static RelDataType
extractLastNFields(RelDataTypeFactory
This is an automated email from the ASF dual-hosted git repository.
mbudiu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new ea441e7c75 [CALCITE-6365] Support for RETURNING
mihaibudiu merged PR #3771:
URL: https://github.com/apache/calcite/pull/3771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2104930854
## [ in calcite is allowed. The string type and the boolean type are
comparable. I am not sure about
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596944009
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596942382
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
caicancai commented on code in PR #3785:
URL: https://github.com/apache/calcite/pull/3785#discussion_r1596920047
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -10036,6 +10036,45 @@ void assertSubFunReturns(boolean binary, String s, int
start,
sonarcloud[bot] commented on PR #3771:
URL: https://github.com/apache/calcite/pull/3771#issuecomment-2104222197
## [