Re: [PR] [CALCITE-6400] MAP_ENTRIES allows null as a map key [calcite]

2024-05-13 Thread via GitHub
caicancai commented on PR #3787: URL: https://github.com/apache/calcite/pull/3787#issuecomment-2109072431 > The issue is about map_entries, but this PR fixes the arguments to the map constructor. Thanks, I will modify the jira summary, the description is being discussed in jira --

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-13 Thread via GitHub
mihaibudiu commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2109039604 I don't understand why the CI fails. Can you please rebase on main? Maybe it has something to do with the recent transition to 1.37 which had some build system changes. -- This

(calcite) branch main updated: [CALCITE-6313] Add POWER function for PostgreSQL

2024-05-13 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/main by this push: new 5ab4397ac9 [CALCITE-6313] Add POWER function for

Re: [PR] [CALCITE-6313] Add POWER function for PostgreSQL [calcite]

2024-05-13 Thread via GitHub
mihaibudiu merged PR #3762: URL: https://github.com/apache/calcite/pull/3762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6392] Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp [calcite]

2024-05-13 Thread via GitHub
mihaibudiu commented on PR #3791: URL: https://github.com/apache/calcite/pull/3791#issuecomment-2109036754 I have reverted these 6 commits merged by mistake in main. Can you please resubmit these as a separate PR? It looks like a merged PR cannot be reopened. -- This is an

(calcite) branch main updated (4b73a2f15e -> c228804e25)

2024-05-13 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git omit 4b73a2f15e Updated annotation order omit a9aff1f9db Fixed up nullable declarations omit b2aff8cf9d Removed an

Re: [PR] [CALCITE-6392] Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp [calcite]

2024-05-13 Thread via GitHub
mihaibudiu commented on PR #3791: URL: https://github.com/apache/calcite/pull/3791#issuecomment-2109027856 oops, I merged the wrong PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(calcite) branch main updated (c228804e25 -> 4b73a2f15e)

2024-05-13 Thread mbudiu
This is an automated email from the ASF dual-hosted git repository. mbudiu pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/calcite.git from c228804e25 [CALCITE-6389] RexBuilder.removeCastFromLiteral does not preserve semantics for some types of literal

Re: [PR] [CALCITE-6392] Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp [calcite]

2024-05-13 Thread via GitHub
mihaibudiu merged PR #3791: URL: https://github.com/apache/calcite/pull/3791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [CALCITE-6392] Support all PostgreSQL 14 date/time patterns for to_date/to_timestamp [calcite]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #3791: URL: https://github.com/apache/calcite/pull/3791#issuecomment-2108867042 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2108837190 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6400] MAP_ENTRIES allows null as a map key [calcite]

2024-05-13 Thread via GitHub
mihaibudiu commented on PR #3787: URL: https://github.com/apache/calcite/pull/3787#issuecomment-2108669763 The issue is about map_entries, but this PR fixes the arguments to the map constructor. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-13 Thread via GitHub
sonarcloud[bot] commented on PR #3785: URL: https://github.com/apache/calcite/pull/3785#issuecomment-2108615228 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-13 Thread via GitHub
normanj-bitquill commented on code in PR #3773: URL: https://github.com/apache/calcite/pull/3773#discussion_r1598814257 ## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ## @@ -1651,13 +1652,22 @@ private static RelDataType

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-13 Thread via GitHub
caicancai commented on PR #3785: URL: https://github.com/apache/calcite/pull/3785#issuecomment-2107959410 @mihaibudiu Hello, I opened jira to discuss the comparability of character and boolean types because I'm not sure if this is a bug. https://issues.apache.org/jira/browse/CALCITE-6409