Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111333588 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111330588 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111322200 Please retry analysis of this Pull-Request directly on SonarCloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111322103 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111284526 Locally with a fresh checkout I get: ``` Skipping task ':buildSrc:autostyleKotlinGradleCheck' as it is up-to-date. ``` For the Windows build, I get: ```

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111278392 I have no idea about the Windows build errors. It fails trying to do task `:buildSrc:autostyleKotlinGradleCheck`. It fails since it can't find the class

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2111095551 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-14 Thread via GitHub
mihaibudiu commented on code in PR #3785: URL: https://github.com/apache/calcite/pull/3785#discussion_r1600522936 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -551,6 +551,13 @@ public static SqlCall stripSeparator(SqlCall call) { opBinding ->

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2110803385 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

2024-05-14 Thread via GitHub
normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2110538944 > I don't understand why the CI fails. Can you please rebase on main? Maybe it has something to do with the recent transition to 1.37 which had some build system changes.

Re: [PR] [CALCITE-6397] Add NVL2 function (enabled in Oracle, Spark library) [calcite]

2024-05-14 Thread via GitHub
caicancai commented on PR #3785: URL: https://github.com/apache/calcite/pull/3785#issuecomment-2110531888 @mihaibudiu PATL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre [calcite]

2024-05-14 Thread via GitHub
snuyanzin commented on PR #3240: URL: https://github.com/apache/calcite/pull/3240#issuecomment-2109559682 closing, since the issue was solved in later guava versions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre [calcite]

2024-05-14 Thread via GitHub
snuyanzin closed pull request #3240: [CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre URL: https://github.com/apache/calcite/pull/3240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [CALCITE-6400] MAP_ENTRIES function should throw if a key value is null [calcite]

2024-05-14 Thread via GitHub
sonarcloud[bot] commented on PR #3787: URL: https://github.com/apache/calcite/pull/3787#issuecomment-2109464195 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate