Re: [PR] [CALCITE-6340] RelBuilder drops set conventions when aggregating over duplicate projected fields [calcite]

sonarcloud[bot] commented on PR #3757: URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113237120 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6340] RelBuilder drops set conventions when aggregating over duplicate projected fields [calcite]

sonarcloud[bot] commented on PR #3757: URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113195784 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns for to_char [calcite]

sonarcloud[bot] commented on PR #3792: URL: https://github.com/apache/calcite/pull/3792#issuecomment-2113157600 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

mihaibudiu commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113141295 Anything that works correctly is fine for me. Please note that I am on vacation so I won't have time to review this soon. -- This is an automated message from the Apache Git

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

sonarcloud[bot] commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113069331 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [CALCITE-6340] RelBuilder drops set conventions when aggregating over duplicate projected fields [calcite]

jduo commented on code in PR #3757: URL: https://github.com/apache/calcite/pull/3757#discussion_r1601998815 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -1450,6 +1452,225 @@ private RexNode caseCall(RelBuilder b, RexNode ref, RexNode... nodes) {

Re: [PR] [CALCITE-6340] RelBuilder drops set conventions when aggregating over duplicate projected fields [calcite]

jduo commented on PR #3757: URL: https://github.com/apache/calcite/pull/3757#issuecomment-2113060675 > Few more minor changes and for me we are good to go. > > Please don't force-push until the review process is on-going as it makes incremental reviewing more difficult. In

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns for to_char [calcite]

normanj-bitquill commented on PR #3792: URL: https://github.com/apache/calcite/pull/3792#issuecomment-2113054134 This PR is the same as https://github.com/apache/calcite/pull/3773 Needed to recreate to fix CI issues. -- This is an automated message from the Apache Git Service.

Re: [PR] [CALCITE-6358] Support all PostgreSQL 14 date/time patterns [calcite]

normanj-bitquill commented on PR #3773: URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113053216 @mihaibudiu I tried creating a new PR here, that did build correctly. https://github.com/apache/calcite/pull/3792 If you are OK with it, we should just use that PR and

Re: [PR] [CALCITE-6340] RelBuilder drops set conventions when aggregating over duplicate projected fields [calcite]

asolimando commented on code in PR #3757: URL: https://github.com/apache/calcite/pull/3757#discussion_r1601900134 ## core/src/test/java/org/apache/calcite/test/RelBuilderTest.java: ## @@ -1450,6 +1452,225 @@ private RexNode caseCall(RelBuilder b, RexNode ref, RexNode... nodes)