[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

Aaron edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303 > > The code looks really redundant, cuz RelDistribution#getKeys is annotated as nonnull, and must return "List". > > Or do I miss something? > > It is

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

Aaron edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-647071463 > I don't think there is any confusion. I've updated my PR with less code and keep semantically unchanged(hash keys are empty, for forward compatible),

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

Aaron edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303 > > The code looks really redundant, cuz RelDistribution#getKeys is annotated as nonnull, and must return "List". > > Or do I miss something? > > It is

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

Aaron edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-646487303 > > The code looks really redundant, cuz RelDistribution#getKeys is annotated as nonnull, and must return "List". > > Or do I miss something? > > It is

[GitHub] [calcite] Aaaaaaron edited a comment on pull request #2030: minor, remove redundant code in "RelJson.toJson(RelDistribution)".

Aaron edited a comment on pull request #2030: URL: https://github.com/apache/calcite/pull/2030#issuecomment-645239663 The code looks really redundant, cuz RelDistribution#getKeys is annotated as nonnull, and must return "List". Or do I miss something?