[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1310631115 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -554,6 +555,7 @@ Builder populate() { defineMethod(SPLIT, "split",

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1310628458 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1310617255 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -569,6 +570,8 @@ Builder populate() { defineReflective(PARSE_URL,

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1305968899 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300724825 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -355,19 +355,88 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300710439 ## site/_docs/reference.md: ## @@ -2783,7 +2783,9 @@ BigQuery's type system uses confusingly different names for types and functions: | h s | PARSE_URL(urlString,

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1300688546 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4568,6 +4568,25 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3369: [CALCITE-5910] Add REGEXP_EXTRACT and REGEXP_SUBSTR functions (enabled in BigQuery library)

Anthrino commented on code in PR #3369: URL: https://github.com/apache/calcite/pull/3369#discussion_r1297809339 ## babel/src/test/resources/sql/big-query.iq: ## @@ -3657,4 +3915,5 @@ FROM items; !ok + Review Comment: They popped up with the auto formatting, I'll take