[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1312041006 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -4675,6 +4675,29 @@ private static void checkIf(SqlOperatorFixture f) {

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1310898531 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -347,19 +347,119 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1304824756 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -347,19 +347,119 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1304821484 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -347,19 +347,119 @@ public static String sha512(ByteString string) { } /** SQL

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1303361167 ## core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java: ## @@ -216,6 +216,8 @@ import static

[GitHub] [calcite] Anthrino commented on a diff in pull request #3387: [CALCITE-5911] Add REGEXP_EXTRACT_ALL function (enabled in BigQuery library)

Anthrino commented on code in PR #3387: URL: https://github.com/apache/calcite/pull/3387#discussion_r1303358903 ## core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java: ## @@ -347,19 +347,119 @@ public static String sha512(ByteString string) { } /** SQL