[GitHub] [calcite] Jiabao-Sun commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-21 Thread via GitHub
Jiabao-Sun commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r119224 ## core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java: ## @@ -645,6 +645,13 @@ public static SqlCall stripSeparator(SqlCall call) { public static

[GitHub] [calcite] Jiabao-Sun commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-16 Thread via GitHub
Jiabao-Sun commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r1327999465 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture

[GitHub] [calcite] Jiabao-Sun commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-16 Thread via GitHub
Jiabao-Sun commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r1327990074 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture

[GitHub] [calcite] Jiabao-Sun commented on a diff in pull request #3430: [CALCITE-6008] ARRAY_AGG should returns ARRAY NULL when there's no input rows

2023-09-16 Thread via GitHub
Jiabao-Sun commented on code in PR #3430: URL: https://github.com/apache/calcite/pull/3430#discussion_r1327989243 ## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ## @@ -9314,11 +9314,12 @@ private static void checkGroupConcatFuncFails(SqlOperatorFixture