amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-683150884
@rubenada maybe we can tag this PR as `LGTM merging soon` to attract people
to review, if anyone has an interest?
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-679262806
Ok I should have addressed existing comments. Thanks @rubenada for the
review!
@hsyuan do you want to take a final look?
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-676721751
Have also rebased this PR against latest master.
This is an automated message from the Apache Git Service.
To
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-676720960
@rubenada
Have tried to address your comments. PTAL, thanks!
This is an automated message from the
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-675902415
Thanks @rubenada for your help!
This is an automated message from the Apache Git Service.
To respond to the
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-654598360
@hsyuan
As people has started to discuss 1.24.0 release, do you think if we could
make this change in 1.24.0?
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-647042133
Tried to rebase this PR, squashed commits and added a detailed commit
message.
This is an automated message
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-643900365
Updated this PR (but assume that CALCITE-4010 will be addressed)
This is an automated message from the
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-643822485
O nice. Didn't realize there is already a JIRA to refine the code generation
implementation of MergeJoin.
Ok then in this PR I will make the assumption that physical
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-643722774
Ok, in fact, I need to refactor a lot on this PR.
I ignored one biggest fact, which caused my implementation wrong in some
places.
Basically, I believe, per
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-643500881
Friendly ping~
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-641756134
Rebased and comments addressed.
This is an automated message from the Apache Git Service.
To respond to the
amaliujia commented on pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#issuecomment-640180682
R: @hsyuan
This is an automated message from the Apache Git Service.
To respond to the message, please log
13 matches
Mail list logo
