[GitHub] [calcite] chucheng92 commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1683363226 Thank you all for patient reviewing, all comments are resolved. @NobiGo hi, xiong, If you help time, could you help to merge it? -- This is an automated message from the Apache Git

[GitHub] [calcite] chucheng92 commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1678455587 > looks great, only left one comments, which should be changed @chucheng92 thanks Lau, you are right. here we need also using leastRestrictive type just like other array

[GitHub] [calcite] chucheng92 commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1667627032 @NobiGo hi, I have solved all your comments. If you have time, pls help to re-check it. thank you. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] chucheng92 commented on pull request #3320: [CALCITE-5830] Add ARRAY_INSERT function(enabled in Spark library)

chucheng92 commented on PR #3320: URL: https://github.com/apache/calcite/pull/3320#issuecomment-1667098566 @NobiGo hi, sorry to ping you. I have solved some comments. If you have time, pls take a look. thanks. -- This is an automated message from the Apache Git Service. To respond to the