danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r520276932
##
File path: core/src/main/java/org/apache/calcite/util/RangeSets.java
##
@@ -128,6 +129,14 @@ private RangeSets() {}
&& !range.isEmpty();
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r520276359
##
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##
@@ -1687,10 +1687,8 @@ private void checkExponentialCnf(int n) {
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r518506310
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
@@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517869098
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
@@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517861261
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
@@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517834372
##
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##
@@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517845516
##
File path: core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml
##
@@ -6217,7 +6217,7 @@ LogicalProject(EXPR$0=[1])
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517845288
##
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##
@@ -1475,11 +1476,11 @@ private void checkExponentialCnf(int n) {
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517845409
##
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##
@@ -1846,7 +1880,7 @@ private void checkExponentialCnf(int n) {
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517834372
##
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##
@@ -2710,6 +2710,16 @@ private boolean accept1(RexNode e, SqlKind kind,
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517831463
##
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##
@@ -1774,6 +1770,27 @@ private void checkExponentialCnf(int n) {
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r517056551
##
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##
@@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs
danny0405 commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r516407768
##
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##
@@ -1330,7 +1330,7 @@ RexNode simplifyAnd(RexCall e, RexUnknownAs
13 matches
Mail list logo