[GitHub] [calcite] jiefei30 commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

2023-09-28 Thread via GitHub
jiefei30 commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1738820448 @JiajunBernoulli Sorry, I just accidentally closed this pr ccause I pressed the wrong button. I opened it again. I added a unit test of `leftAntiJoin` with `SqlParserFixture.DEFAULT`

[GitHub] [calcite] jiefei30 commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

2023-09-28 Thread via GitHub
jiefei30 commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1738811149 > All checks have passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] jiefei30 commented on pull request #3399: [CALCITE-5962] Support parse Spark-style syntax LEFT ANTI JOIN in Babel parser

2023-08-31 Thread via GitHub
jiefei30 commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1700836979 > Hi @jiefei30, I think you should consider this PR[#3291], LEFT ANTI JOIN should not refer right-hand table. @macroguo-ghy ok, thanks for your suggestion, I'll check it --