[GitHub] [calcite] julianhyde commented on pull request #2238: [CALCITE-4364] `a IN (1, 2) AND a = 1` should be simplified to `a = 1`

2020-11-05 Thread GitBox
julianhyde commented on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-722660218 @danny0405 The comment threads on this PR are too long and too forked. I can't see what is the current consensus. I have concerns about generating a large number of diffs.

[GitHub] [calcite] julianhyde commented on pull request #2238: [CALCITE-4364] `a in (1, 2) and a = 1` should be simplified to `a=1`

2020-11-03 Thread GitBox
julianhyde commented on pull request #2238: URL: https://github.com/apache/calcite/pull/2238#issuecomment-720700806 Regarding the commit message: > `a in (1, 2) and a = 1` should be simplified to `a=1` Use upper-case for SQL, and spaces around `=`.