[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-05 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1316730290 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-04 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1314935681 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-04 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1314935681 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-04 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1314806469 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {

[GitHub] [calcite] libenchao commented on a diff in pull request #3311: [CALCITE-5732] EnumerableHashJoin and EnumerableMergeJoin on composite key return rows matching condition 'null = null'

2023-09-02 Thread via GitHub
libenchao commented on code in PR #3311: URL: https://github.com/apache/calcite/pull/3311#discussion_r1311102272 ## linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java: ## @@ -4495,6 +4492,27 @@ private boolean advanceRight(TInner right, TKey rightKey) {