[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-06-05 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1577690670 Hi @tanclary @JiajunBernoulli could you help merged, otherwise it will conflict with my other pre. Thanks very much -- This is an automated message from the Apache Git Service. To

[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-06-05 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1576628815 hi @tanclary will it be merged now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-06-02 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1573906121 fix conflicts with main branch and squash the commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-06-01 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1572926486 hi @tanclary thanks for your review, i have fixed all your reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-05-31 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1571271629 hi @MasseGuillaume @JiajunBernoulli if you have time, also can help review it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] liuyongvs commented on pull request #3236: [CALCITE-5738] Add SORT_ARRAY function (enabled in Spark library)

2023-05-31 Thread via GitHub
liuyongvs commented on PR #3236: URL: https://github.com/apache/calcite/pull/3236#issuecomment-1571271199 hi @tanclary could you help review it, i found you does it in PERCENTILE_CONT/PERCENTILE_DISC, will be familiar with this -- This is an automated message from the Apache Git