liyafan82 edited a comment on issue #1839: [CALCITE-3836] The hash codes of RelNodes are unreliable URL: https://github.com/apache/calcite/pull/1839#issuecomment-593186192 > TL;DR: it looks like currently there's no justification for the change :-/ > > I'm sorry to disappoint you, but > > > For many JVMs, the implementation is based on the object address in the memory > > This is false. Would you please give some docs/link/code proving this? > > > So the hash code of an object may change > > This is false. Would you please give some docs/link/code proving this? > > > This is consistent with the previous semantics, and solves the above problem. > > The new implementation violates `equal` and `hashCode` contract :-/ Sorry. I do not understand why it violates the contract. Would you please elaborate more on this? @vlsi Thanks a lot for your feedback. Looking forward to more feedback from you :-)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
