mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1682362335
We could also regenerate the golden file to account for the fixes made in
the meantime. But I am on vacation for the next week so I can't do it right
away.
--
This is an automated
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1624391721
I wasn't exactly sure how to handle this, so what I have done is to:
- run just one test file as a slow test, takes a couple of minutes
- disable the full testsuite using the
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1613354307
On my machine using 8 parallel threads the tests take about 5-6 hours.
I am not familiar with the tiers of tests in Calcite, so I don't know what
tag should be used., but if there
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1603442065
I hope we're close to a working solution for this PR.
You will notice that the CalciteExecutor has been reduced to just a few
lines of code.
Most of the complexity is in the
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1581672584
I apologize, didn't realize it's that involved. Any way I can help?
I hope this will be the last one for a while.
--
This is an automated message from the Apache Git Service.
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1581668067
Well, you said "release often". Is there something that prevents a new
release of sql-logic-test?
Unfortunately the code was missing some getters for non-public members and I
don't
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1581359888
I have amended this PR to use DynamicTests. This needs
https://github.com/hydromatic/sql-logic-test/pull/36 in order to work, so a new
release of sql-logic-tests is necessary. This
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1581208831
I think having many small tests is probably better. There are 622 test files
in the project.
We could write a small script to generate a test for each one (or a group of
files).
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1572795640
It took about 6 minutes to run 10K tests using CalciteExecutor, so by
extrapolation it would take about 2 days to run all tests.
Memory consumption increases slightly with time. The
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1563493613
Currently the "execute" method from Main only returns an integer and writes
all diagnostic to the supplied streams.
We have to make it return the actual TestStatistics object.
So
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1540542474
With the latest commit this is testing the CalciteExecutor against the
candidate 0.2 release of sql-logic-test.
--
This is an automated message from the Apache Git Service.
To
mihaibudiu commented on PR #3145:
URL: https://github.com/apache/calcite/pull/3145#issuecomment-1536875335
@zabetak thank you for the comments, I will address them once sql-logic-test
2.0 is available in my next PR.
But I would appreciate help to decide how to package this tool.
--
12 matches
Mail list logo
