[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-10 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611911050 @danny0405 Many thanks for your advice. Can I close this PR and open a new one only to add unit

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-10 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611891530 @hsyuan Thanks for your advice about softValues,

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-10 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611891530 @hsyuan Thanks for your advice about softValues. Actually now I am a little reluctant to the

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611042597 @vlsi Thank you for your quick response. I have added new benchmark test case for baseline to

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-08 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-611042597 @vlsi Thank you for your quick response. I have added new benchmark test case for baseline to

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-01 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-607168132 @vlsi I have addressed your comments. 1) Set max cache to 0 to disable global caching. 2)

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-01 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-607168132 @vlsi I have addressed your comments. 1) Set max cache to 0 to disable global caching. 2)

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-04-01 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-607168132 @vlsi I have addressed your comments. 1) Set max cache to 0 to disable global caching. 2)

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-03-28 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-605405488 @vlsi I refined the benchmark in [my

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-03-28 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-605405488 @vlsi I refined the benchmark in [my

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-03-27 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418 @vlsi I have added benchmark to `ubenchmark` module. As @hsyuan suggested, I make global

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-03-27 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418 @vlsi I have added benchmark to `ubenchmark` module. As @hsyuan suggested, I make global

[GitHub] [calcite] neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

2020-03-27 Thread GitBox
neoremind edited a comment on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation URL: https://github.com/apache/calcite/pull/1875#issuecomment-605091418 @vlsi I have add benchmark to `ubenchmark` module. As @hsyuan suggested, I make global