[GitHub] [calcite] rubenada commented on a diff in pull request #3390: [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails

2023-09-25 Thread via GitHub
rubenada commented on code in PR #3390: URL: https://github.com/apache/calcite/pull/3390#discussion_r1335483866 ## core/src/main/java/org/apache/calcite/rex/RexExecutable.java: ## @@ -87,11 +88,14 @@ public void reduce(RexBuilder rexBuilder, List constExps, values =

[GitHub] [calcite] rubenada commented on a diff in pull request #3390: [CALCITE-5949] RexExecutable should return unchanged original expressions when it fails

2023-09-11 Thread via GitHub
rubenada commented on code in PR #3390: URL: https://github.com/apache/calcite/pull/3390#discussion_r1321146914 ## core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java: ## @@ -378,4 +378,28 @@ public void run() { interface Action { void check(RexBuilder