[GitHub] [calcite] rubenada commented on pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-26 Thread via GitHub
rubenada commented on PR #3214: URL: https://github.com/apache/calcite/pull/3214#issuecomment-1563944729 Thanks @tanclary ! @zoudan could you please squash commits into a single one? I'll proceed with the merge afterwards. -- This is an automated message from the Apache Git

[GitHub] [calcite] rubenada commented on pull request #3214: [CALCITE-5608] Implement ASINH, ACOSH, ATANH functions

2023-05-25 Thread via GitHub
rubenada commented on PR #3214: URL: https://github.com/apache/calcite/pull/3214#issuecomment-1562918294 @tanclary I see you have participated on other trigonometric-related PRs, would you like to take a look at this one? I think it is in a good shape and I will proceed to merge (after